New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733039 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 734167
issue 734190



Sign in to add a comment

turn down alerts-dispatcher

Project Member Reported by seanmccullough@chromium.org, Jun 14 2017

Issue description

Now that the last tree has been moved to the GAE cron analyzer tasks (as of <https://chromium-review.googlesource.com/c/533639/>), we can go about turning down alerts-dispatcher. Yay.

To minimize disruption, how about the following sequence of events:

* Step 0: turn alerting for alerts-dispatcher (disable, or actually delete alert configs altogether?)

Alert config for a-d is here: https://cs.corp.google.com/piper///depot/google3/configs/monitoring/chrome_infra/task_alerts.py?q=AlertsDispatcherZeroSuccess&sq=package:piper+file://depot/google3+-file:google3/experimental&l=156

* Step 1: tell infra.cron master to stop running alerts-dispatcher's builder recipe:

Remove alerts-dispatcher config sections from
build_internal/masters/master.internal.infra.cron/master.cfg

and it's slave config from
build_internal/masters/master.internal.infra.cron/slaves.cfg

Something like this CL: https://chrome-internal-review.googlesource.com/c/394350/ ?

* Step 2: Let Infra-labs know they can de-provision slave82-c7 (prod) and slave26-c7 (staging)

* Step 3: remove alerts-dispatcher related recipe code from the repo: 
https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/master/recipes/infra/alerts_dispatcher.py

* Step 4: Remove go/trooper playbook sections on alerts-dispatcher

* Step 5: Remove alerts-dispatcher from viceroy dashboards.

* Step 6: Ain't no party like to turn-down party 'cause a turn-down party does in fact stop.
 
Status: Started (was: Available)
Stop 0, turn off alerting: https://critique.corp.google.com/#review/159162371
Description: Show this description
Step 0 committed.

Step 1, stop infra.cron jobs, remove builder/slave configs: https://chrome-internal-review.googlesource.com/c/394350/
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/9ed1017f121de031f7393efd12f9938f766de231

commit 9ed1017f121de031f7393efd12f9938f766de231
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Jun 16 19:01:59 2017

Blockedon: 734190
Step 3, remove the recipe code from the repo: https://chrome-internal-review.googlesource.com/c/396711/

Step 4, remove playbook entries: https://chrome-internal-review.googlesource.com/c/396712/
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/aa0ef449936f97652d01af131c54540e555971cd

commit aa0ef449936f97652d01af131c54540e555971cd
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Jun 16 20:44:55 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 16 2017

Status: Fixed (was: Started)
Step 5 is complete. All that is left is for labs to reclaim the VMs.

Closing.

Comment 13 by mmoss@chromium.org, Sep 13 2017

I just noticed that https://uberchromegw.corp.google.com/i/official.infra.cron/builders/alerts-dispatcher is still running (and failing). I assume it's safe to remove that as well?
yes!
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/6cec85523d81a4a82bdd17066c2c0929ec922ee1

commit 6cec85523d81a4a82bdd17066c2c0929ec922ee1
Author: Michael Moss <mmoss@google.com>
Date: Wed Sep 13 22:51:02 2017

Sign in to add a comment