New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733029 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 733030
issue 733382
issue 740081

Blocking:
issue 664630



Sign in to add a comment

Merge WebAuthN with CredMan API

Project Member Reported by kpaulhamus@chromium.org, Jun 14 2017

Issue description

WebAuthN WD-05 extends the Credential Manager API. 

The intent of this bug is to track the merge with CredMan.
 
Blockedon: 733030
Blocking: 664630
Blockedon: 733382
Blockedon: 740081
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be8c5bb615006096979f5958ef5adb2786f4777

commit 6be8c5bb615006096979f5958ef5adb2786f4777
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Mon Aug 14 19:47:32 2017

Migrate webauthn to the credentialmanager module.

This change moves the idl and implementation from
modules/webauth/ to modules/credentialmanager and implements 
the creation of a publicKeyCredential via 
navigator.credentials.create(). The call uses 
WebAuthenticationClient to dispatch publicKeyCredential
operations to the browser-side mojo implementation.

This change also mocks the the browser-side implementation
of authenticator.mojom and adds layout tests using test_runner.

This change freezes the spec at WD05 for interop.
Spec WD05: https://www.w3.org/TR/2017/WD-webauthn-20170505/

Bug:  733029 
Change-Id: I4fcd01295f640c7500b815232c8f6cec5b3a2409
Reviewed-on: https://chromium-review.googlesource.com/578729
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494140}
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/DEPS
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/mock_authenticator.cc
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/mock_authenticator.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/mock_credential_manager_client.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/content/shell/test_runner/web_test_runner.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/services/service_manager/public/cpp/interface_provider.h
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https-expected.txt
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https.html
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/BUILD.gn
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.cpp
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.h
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAttestationResponse.cpp
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAttestationResponse.h
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAttestationResponse.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorResponse.cpp
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorResponse.h
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorResponse.idl
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorSelectionCriteria.idl
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/BUILD.gn
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CollectedClientData.idl
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CredentialCreationOptions.idl
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/MakeCredentialOptions.idl
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.cpp
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.h
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialDescriptor.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialEntity.idl
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialParameters.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialRequestOptions.idl
[rename] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialUserEntity.idl
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[add] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.h
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.idl
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/AuthenticatorSelectionCriteria.idl
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/BUILD.gn
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/DEPS
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/NavigatorAuth.h
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/NavigatorAuth.idl
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/OWNERS
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.cpp
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialParameters.idl
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
[delete] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
[modify] https://crrev.com/6be8c5bb615006096979f5958ef5adb2786f4777/third_party/WebKit/public/platform/WebCredentialManagerError.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d2c5c70c83497290d59e87c92d59a674b5a7c7

commit 08d2c5c70c83497290d59e87c92d59a674b5a7c7
Author: Reilly Grant <reillyg@chromium.org>
Date: Mon Aug 14 23:36:24 2017

Revert "Migrate webauthn to the credentialmanager module."

This reverts commit 6be8c5bb615006096979f5958ef5adb2786f4777.

Reason for revert: credentialscontainer-create-basics.https.html and credentialscontainer-create-basics.html began consistently leaking with this change. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/8171

Original change's description:
> Migrate webauthn to the credentialmanager module.
> 
> This change moves the idl and implementation from
> modules/webauth/ to modules/credentialmanager and implements 
> the creation of a publicKeyCredential via 
> navigator.credentials.create(). The call uses 
> WebAuthenticationClient to dispatch publicKeyCredential
> operations to the browser-side mojo implementation.
> 
> This change also mocks the the browser-side implementation
> of authenticator.mojom and adds layout tests using test_runner.
> 
> This change freezes the spec at WD05 for interop.
> Spec WD05: https://www.w3.org/TR/2017/WD-webauthn-20170505/
> 
> Bug:  733029 
> Change-Id: I4fcd01295f640c7500b815232c8f6cec5b3a2409
> Reviewed-on: https://chromium-review.googlesource.com/578729
> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494140}

TBR=rockot@chromium.org,engedy@chromium.org,kpaulhamus@chromium.org,mkwst@chromium.org

Change-Id: Ibdda6fcc61883193a28ec29a9066d98a4dda0206
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  733029 
Reviewed-on: https://chromium-review.googlesource.com/614803
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494247}
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/DEPS
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/content/shell/test_runner/mock_authenticator.cc
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/content/shell/test_runner/mock_authenticator.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/mock_credential_manager_client.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/content/shell/test_runner/web_test_runner.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/services/service_manager/public/cpp/interface_provider.h
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https-expected.txt
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https.html
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/BUILD.gn
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.idl
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorSelectionCriteria.idl
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/BUILD.gn
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/CredentialCreationOptions.idl
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.cpp
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialParameters.idl
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[delete] https://crrev.com/4ffc6e196e3de439f190b42076a7f1e76ded72c2/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.h
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/modules_idl_files.gni
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.cpp
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.cpp
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.cpp
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.h
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/AuthenticatorSelectionCriteria.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/BUILD.gn
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/CollectedClientData.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/DEPS
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/MakeCredentialOptions.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/NavigatorAuth.h
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/NavigatorAuth.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/OWNERS
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.cpp
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.h
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialDescriptor.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialEntity.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialParameters.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl
[rename] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialUserEntity.idl
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
[add] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
[modify] https://crrev.com/08d2c5c70c83497290d59e87c92d59a674b5a7c7/third_party/WebKit/public/platform/WebCredentialManagerError.h

Status: Fixed (was: Assigned)

Sign in to add a comment