New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

"package build" step fails across all waterfall builders

Project Member Reported by vadimsh@chromium.org, Jun 13 2017

Issue description

Cc: dalecur...@chromium.org
Owner: alokp@chromium.org
Last green build has 'build' repo at revision 7d9828c3c0e1badbb66920ee7670323d4a413407
First purple build has it at revision fe4f4dd5db59a1a170fe01e0899bbb5da84b7c78

The only suspicious commit between this two revisions is https://chromium.googlesource.com/chromium/tools/build/+/f08870a5443018f07f0a7a612733fea2210458ac

I've attempted to revert it, but Alok landed CLs with fixes before me:
https://chromium-review.googlesource.com/c/534539/
https://chromium-review.googlesource.com/c/534658/

Reassigning to Alok to confirm the fix.

Comment 2 by alokp@chromium.org, Jun 14 2017

I am watching the builds to see if those patches fix the build. If they do not turn green, we should revert all three patches.

Sadly there is no way to test changes to zip_build.py locally or the CQ.

Comment 3 by alokp@chromium.org, Jun 14 2017

I have uploaded a patch here: https://chromium-review.googlesource.com/c/535033/

Vadim: Feel free to land it if the builders do not turn green. Sorry I need to go pick up kids.
Cc: alokp@chromium.org
Owner: vadimsh@chromium.org
Yep, I'll be monitoring the builds.
This build should have picked up the fix: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/85676

It failed with:

Removing /b/c/chrome_staging/full-build-linux
Now, os.path.exists(/b/c/chrome_staging/full-build-linux): False
Traceback (most recent call last):
  File "/b/rr/tmptHLZrI/rw/checkout/scripts/slave/zip_build.py", line 563, in <module>
    sys.exit(main(sys.argv))
  File "/b/rr/tmptHLZrI/rw/checkout/scripts/slave/zip_build.py", line 551, in main
    urls = Archive(options)
  File "/b/rr/tmptHLZrI/rw/checkout/scripts/slave/zip_build.py", line 418, in Archive
    strip_files=options.strip_files)
  File "/b/rr/tmptHLZrI/rw/checkout/scripts/slave/zip_build.py", line 204, in MakeUnversionedArchive
    strip_files=strip_files)
  File "/b/rr/tmptHLZrI/rw/checkout/scripts/common/chromium_utils.py", line 676, in MakeZip
    shutil.copytree(src_path, dst_path, symlinks=True)
  File "/usr/lib/python2.7/shutil.py", line 177, in copytree
    os.makedirs(dst)
  File "/usr/lib/python2.7/os.py", line 157, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists: '/b/c/chrome_staging/full-build-linux/.'

---

Notice the "./" at the end. I think it's related to https://chromium.googlesource.com/chromium/tools/build/+/9a1c6fb1e2b18ae3c187a0ca57bcfc36cce08679

So I'll commit your revert (https://chromium-review.googlesource.com/c/535033/), just to be sure.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d75d0aac27f884f39068b1f24739934c45f1284a

commit d75d0aac27f884f39068b1f24739934c45f1284a
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Wed Jun 14 00:56:24 2017

Fixes builder breakage due to mojo js bindings.

I have reverted including the file in test package but left logging to
diagnose this issue.

Bug:733027
Change-Id: I48ff97c760ff63e3b3f1a90ddf0093d605536872
Reviewed-on: https://chromium-review.googlesource.com/535033
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/d75d0aac27f884f39068b1f24739934c45f1284a/scripts/slave/zip_build.py

Status: Fixed (was: Assigned)
The revert helped: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/85679

Closing this for now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/92d7b726f2a92520f6d187f4135cb3b25ef54b73

commit 92d7b726f2a92520f6d187f4135cb3b25ef54b73
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Thu Jun 15 04:23:58 2017

Adds unittest for zip_build.Archive.

Bug:  733027 
Change-Id: Iff918dc5e2b136bf76d29d3d9ad3d782e2ad5788
Reviewed-on: https://chromium-review.googlesource.com/536236
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[modify] https://crrev.com/92d7b726f2a92520f6d187f4135cb3b25ef54b73/scripts/slave/unittests/zip_build_test.py
[modify] https://crrev.com/92d7b726f2a92520f6d187f4135cb3b25ef54b73/scripts/slave/zip_build.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4a35529136e78c57ef67a7aa6989616bcf601715

commit 4a35529136e78c57ef67a7aa6989616bcf601715
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Thu Jun 15 18:18:26 2017

Fix the list of files to zip by appending instead extending.

Bug:  733027 
Change-Id: I0e8330b487e43a231d69f32dda689dae61b0b294
Reviewed-on: https://chromium-review.googlesource.com/534976
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/4a35529136e78c57ef67a7aa6989616bcf601715/scripts/slave/unittests/zip_build_test.py
[modify] https://crrev.com/4a35529136e78c57ef67a7aa6989616bcf601715/scripts/slave/zip_build.py

Sign in to add a comment