New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733023 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Checking process IDs on the is_transfer_to_same path is problematic with process reuse

Project Member Reported by alex...@chromium.org, Jun 13 2017

Issue description

NavigatorImpl::NavigateToEntry currently checks whether a request results in a transfer to the same RenderFrameHost that started the request using process IDs:

    bool is_transfer_to_same =
        is_transfer &&
        entry.transferred_global_request_id().child_id ==
            dest_render_frame_host->GetProcess()->GetID();

This is problematic if we've over process limit.  For example, if foo.com navigates cross-process to bar.com, and foo and bar SiteInstances end up sharing the same RenderProcessHost, this will cause us to first initiate a transfer in RenderFrameHostManager::UpdateStateForNavigate because the SiteInstances are different, but then we'll incorrectly think that the transfer is to the same RFH that started the request and not send the Navigate IPC.  This will cause the navigation to hang.

I first hit this for isolated origins while working on https://codereview.chromium.org/2921063003.  Charlie mentions that this also might come up for a redirect from one extension to another when we're over the process limit and the extensions end up sharing a process.  

This path is only used without PlzNavigate, and I've confirmed this isn't a problem with PlzNavigate enabled.  So we could just wait for PlzNavigate to ship to get this fixed.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by nasko@chromium.org, Jun 14 2018

Status: WontFix (was: Untriaged)
PlzNavigate is now the only navigation code and transferred_global_request_id was removed from the codebase. We can close this one as WontFix.

Sign in to add a comment