New issue
Advanced search Search tips

Issue 733000 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

content_browsertests failing on chromium.linux/Cast Audio Linux

Project Member Reported by dalecur...@chromium.org, Jun 13 2017

Issue description

content_browsertests failing on chromium.linux/Cast Audio Linux

Builders failed on: 
- Cast Audio Linux: 
  https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux


Looks like 4b67e647524bd9468385def24fe99beceeb21e99 broke this; but for some reason this bot isn't on the CQ...
 
Labels: Pri-1 Type-Bug-Regression
I'll revert and try to reproduce it locally to see what is going on.

Comment 3 by ortuno@chromium.org, Jun 14 2017

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998ec642b28daafb02f595e639a6cd601bdc24a6

commit 998ec642b28daafb02f595e639a6cd601bdc24a6
Author: Christian Fremerey <chfremer@chromium.org>
Date: Fri Jun 16 22:21:54 2017

Reland [Mojo Video Capture] Add integration test for crashing video capture process

PatchSet 1 is state as reviewed and reverted.
PatchSet 2 applies fix

Reason for revert:
The newly added test failed on chromium.linux/Cast Audio Linux with a timeout.

Description of fix
------------------
The test should not be run on that builder. Turns out all other tests of the same kind are conditionally build with build flag |enable_webrtc|. The fix moves/renames the test to match that pattern.

Original CL description
-----------------------
This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL27

Adds a content_browsertest RecoverFromCrashInVideoCaptureProcess, which does the
following:
1. starts video capture
2. verifies that video is rendered
3. finds and forcefully shuts down the process hosting the video capture service
4. verifies that video capturing and rendering stops
5. restarts video capture
6. verifies that it video is rendered again

In order to make this work, I added code for looking up browser child processes
from a string tag, which in case of services is supposed to be set to the
service name.


BUG:584797, 733000 
TEST:
  content_browsertests --gtest_filter="WebRtcVideoCaptureBrowserTest*"
TBR=jam@chromium.org,rockot@chromium.org,emircan@chromium.org,wfh@chromium.org

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Change-Id: If1716f9cfd68535a0f373697c35896dc2903ade7
Reviewed-on: https://chromium-review.googlesource.com/536153
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480198}
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/content/browser/renderer_host/media/service_launched_video_capture_device.cc
[add] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/content/browser/webrtc/webrtc_video_capture_browsertest.cc
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/content/test/BUILD.gn
[add] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/content/test/data/media/video_capture_test.html
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/BUILD.gn
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/public/interfaces/BUILD.gn
[add] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/public/interfaces/testing_controls.mojom
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/service_impl.cc
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/service_impl.h
[modify] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/service_manifest.json
[add] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/testing_controls_impl.cc
[add] https://crrev.com/998ec642b28daafb02f595e639a6cd601bdc24a6/services/video_capture/testing_controls_impl.h

Status: Fixed (was: Assigned)

Sign in to add a comment