Issue metadata
Sign in to add a comment
|
Devtools broken with local commits
Reported by
mcda...@amazon.com,
Jun 13 2017
|
||||||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Make a local commit 2. gclient runhooks 3. Build / install / run chrome_public_apk 4. On desktop, open 'chrome://inspect' and attempt to inspect a webpage running on the apk What is the expected behavior? The remote debugger works correctly, allowing the page to be inspected. What went wrong? The remote debugger displays an error page: 404 Not Found The resource could not be found. Did this work before? Yes Before 69e2570d4b5e50cd708e4c467e567d810c4b2134 Chrome version: master Channel: dev OS Version: any Flash Version: This broke with https://crrev.com/69e2570d4b5e50cd708e4c467e567d810c4b2134, which removed the original fix for this bug https://crrev.com/fb61e3682fe7301373360fa851c7cb3dea9aec1f
,
Jun 13 2017
Yep, another workaround is to 'git checkout' the last valid commit and run gclient runhooks, then re-checkout the local commit again. Just wanted to point out that this was explicitly fixed in that second commit I linked, and seems to have been unintentionally broken again.
,
Jun 19 2017
,
Nov 1 2017
This is not just broken for local commits; this is also broken for all non-.0 tagged release versions I think. The extra commit in, say, 60.0.3112.116 which updates DEPS to the right versions of the dependencies for the .116 build changes the hash and the frontend doesn't match any more. The hook should probably find the last "real" committed commit with a commit position like it used to..
,
Dec 20 2017
,
Dec 20 2017
The issue I point out in comment 4 is pretty bad and makes chromium release builds (unlike Chrome) largely unusable for remote debugging. Was that fixed elsewhere? If not then I think this needs addressing still..
,
Jan 9 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pfeldman@chromium.org
, Jun 13 2017