New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732992 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 710701
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Devtools broken with local commits

Reported by mcda...@amazon.com, Jun 13 2017

Issue description

Steps to reproduce the problem:
1. Make a local commit
2. gclient runhooks
3. Build / install / run chrome_public_apk
4. On desktop, open 'chrome://inspect' and attempt to inspect a webpage running on the apk

What is the expected behavior?
The remote debugger works correctly, allowing the page to be inspected.

What went wrong?
The remote debugger displays an error page:

404 Not Found The resource could not be found.

Did this work before? Yes Before 69e2570d4b5e50cd708e4c467e567d810c4b2134

Chrome version: master  Channel: dev
OS Version: any
Flash Version: 

This broke with https://crrev.com/69e2570d4b5e50cd708e4c467e567d810c4b2134, which removed the original fix for this bug https://crrev.com/fb61e3682fe7301373360fa851c7cb3dea9aec1f
 
We haven't uploaded front-end for your local hash to the server. If you compile desktop version of the browser, I can tell you what to tweak so that it was using local front-end version. Alternatively, consider using legacy remote debugging workflow:
- adb forward android's named socket to 9222
- visit localhost:9222 to obtain debugging web socket name
- open chrome-devtools://devtools/bundled/inspector.html?ws=<WS> in your canary.

Comment 2 by mcda...@amazon.com, Jun 13 2017

Yep, another workaround is to 'git checkout' the last valid commit and run gclient runhooks, then re-checkout the local commit again.

Just wanted to point out that this was explicitly fixed in that second commit I linked, and seems to have been unintentionally broken again.
Labels: -Pri-2 Pri-3
Owner: chenwilliam@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by torne@chromium.org, Nov 1 2017

Cc: torne@chromium.org
This is not just broken for local commits; this is also broken for all non-.0 tagged release versions I think. The extra commit in, say, 60.0.3112.116 which updates DEPS to the right versions of the dependencies for the .116 build changes the hash and the frontend doesn't match any more.

The hook should probably find the last "real" committed commit with a commit position like it used to..
Cc: dgozman@chromium.org
Status: Archived (was: Assigned)

Comment 6 by torne@chromium.org, Dec 20 2017

The issue I point out in comment 4 is pretty bad and makes chromium release builds (unlike Chrome) largely unusable for remote debugging. Was that fixed elsewhere? If not then I think this needs addressing still..

Comment 7 by torne@chromium.org, Jan 9 2018

Mergedinto: 710701
Status: Duplicate (was: Archived)
Merging this into a still-open dupe

Sign in to add a comment