New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732991 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BluetoothAdapter::DevicePairedChanged on Linux?

Project Member Reported by michae...@chromium.org, Jun 13 2017

Issue description

BluetoothAdapter::DevicePairedChanged is confusing. The comment says:

    // This function is implemented for ChromeOS only, and the support for
    // Android, MaxOS and Windows should be added on demand in the future.

But the function is wrapped in:
  #if defined(OS_CHROMEOS) || defined(OS_LINUX)

Is it intentionally enabled on Linux (rather than Chrome OS only)?

If so, the defined(OS_CHROMEOS) is redundant -- Chrome OS implies Linux.

(There are a bunch of repeats of this comment and #ifdef as the function is used or overridden in some places.

https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_adapter.h?type=cs&q=DevicePairedChanged&sq=package:chromium&l=125
 

Comment 1 by scheib@chromium.org, Jun 21 2017

Cc: r...@chromium.org
Owner: michae...@chromium.org
Status: Assigned (was: Untriaged)
No response in a week -- probably just ask rkc in person or over email. Taking it off untriaged lists.

Sign in to add a comment