Reenable PlatformDisplayDefaultTest.EventDispatch |
|||
Issue descriptionThis test worked yesterday on the bots, but failed today. There doesn't seem to have been any change in the interim. Doing some historical builds, this appears to not have worked as early as last week. I am at a loss to explain this result.
,
Jun 14 2017
Issue 733332 has been merged into this issue.
,
Jun 26 2017
It still works for me when I run it as part of services_unittests, but fails if I run with --gtest_filter. The code calling InitializeForGPU in run_all_service_tests.cc isn't [always] executed on PlatformDisplayDefaultTest.EventDispatch's process when it runs as part of the full suite. One way to fix this could be to only do OzonePlatform initialization for the tests that need it and tear it down at the end. Or perhaps break up services_unittests into multiple binaries.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffc48921fecbba1abfa29158bb53f23f7765086c commit ffc48921fecbba1abfa29158bb53f23f7765086c Author: Mike Wasserman <msw@chromium.org> Date: Fri Mar 23 16:59:52 2018 mash: Implement basic display mirroring in the Window Service. Add PlatformDisplayMirror to represent mirroring destination displays. Have ws::DisplayManager own and manage the mirrors as directed by Ash. Add DisplayManager::OnFirstSurfaceActivation helper to notify mirrors. Add FrameGenerator::scale_and_center_ behavior for mirror displays. Minor cleanup and invert a broken conditional in ws::Display. Fix a PlatformDisplay test, add a CreatePlatformWindow helper. Remove an OzonePlatform accessor, I'll fix the test separately. TODO: Get Mash cursor mirroring enabled (via cursor compositing?) Bug: 806318 , 732987 Test: Ctrl+Shift+M toggles display mirroring in --enable-features=Mash Change-Id: I43453a2b76c397a31ebdd8fae7c8fda6399fa4bd Reviewed-on: https://chromium-review.googlesource.com/775653 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545489} [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/BUILD.gn [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display.h [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display_manager.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/display_manager.h [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator.h [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display.h [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_default_unittest.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_delegate.h [add] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_mirror.cc [add] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/platform_display_mirror.h [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/services/ui/ws/window_server.cc [modify] https://crrev.com/ffc48921fecbba1abfa29158bb53f23f7765086c/ui/platform_window/platform_window.h
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29810f4957528d429867fbf815d8c6409dfe8bc2 commit 29810f4957528d429867fbf815d8c6409dfe8bc2 Author: Mike Wasserman <msw@chromium.org> Date: Sat Mar 24 00:09:04 2018 Fix Stub PlatformWindow creation pattern for testing. Avoid overriding the OzonePlatform instance with a test subclass. Instead, have PlatformDisplayDefault make StubWindows for invalid ids. Bug: 732987 Test: Automated Change-Id: I981e844861fbd045eee5436aede91a35c7f8f682 Reviewed-on: https://chromium-review.googlesource.com/978375 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#545643} [modify] https://crrev.com/29810f4957528d429867fbf815d8c6409dfe8bc2/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/29810f4957528d429867fbf815d8c6409dfe8bc2/services/ui/ws/platform_display_default_unittest.cc [modify] https://crrev.com/29810f4957528d429867fbf815d8c6409dfe8bc2/ui/ozone/public/ozone_platform.h
,
Mar 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2017