New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732984 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Order wifi networks by signal strength

Project Member Reported by cernekee@chromium.org, Jun 13 2017

Issue description

Prior to the Material Design changes, Chrome OS used to use shill's network sort order in the system menu's wifi panel.  The sorting logic in Service::Compare is fairly complex, but it roughly follows this:

 - Connected services are at the top of the list
 - Known services are near the top of the list (e.g. SSIDs that have been used before)
 - Unknown services are prioritized based on the technology sort order. i.e. ethernet on top, then wifi, then cellular.
 - More secure services are prioritized above less secure services.  AES is better than RC4.
 - Higher signal strength is prioritized above lower signal strength.

Post-MD, Chrome re-sorts the list and does not use most of these factors.  As a result, most of the unconnected networks on the wifi list are essentially sorted by GUID.  This is a UX regression, as users generally want to see stronger networks on top.  Users do not know about GUIDs.

The proposed change is to remove the Chrome sort and fall back to the shill sort.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81262df9d8ec534bb53421d890e97754cf5a6718

commit 81262df9d8ec534bb53421d890e97754cf5a6718
Author: cernekee <cernekee@chromium.org>
Date: Thu Jun 15 15:44:31 2017

Don't re-sort Chrome OS wifi network list

shill (Service::Compare) already sorts the list based on factors like
network preference, signal strength, security, etc.  After the Material
Design changes, Chrome started reordering the list based on simpler
criteria, and this results in unconnected wifi services being ordered
by GUID instead of signal strength.

To improve the UX, let's revert back to the old ordering method.

BUG= 732984 
TEST=manually build + deploy to samus

Review-Url: https://codereview.chromium.org/2936743003
Cr-Commit-Position: refs/heads/master@{#479716}

[modify] https://crrev.com/81262df9d8ec534bb53421d890e97754cf5a6718/ash/system/network/network_list.cc

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment