Reorder the methods in JumpList class to make it align with the order of executation |
||
Issue descriptionThe methods in the JumpList class are poorly ordered w.r.t the order of their execution in the JumpList update workflow. This makes it difficult to read the JumpList code.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78b03b6957876df0bb887486a085cc77c9b52898 commit 78b03b6957876df0bb887486a085cc77c9b52898 Author: chengx <chengx@chromium.org> Date: Fri Jun 16 18:16:48 2017 Reorder the methods in JumpList class according to the update workflow This CL reorders the methods in JumpList class so that they are laid out approximately in the order they're invoked. The static methods are moved below all other methods since they potentially live somewhere else, e.g., in an unnamed namespace or in a separate class that could be unit-tested independently. After this reordering, the JumpList code should be easier to follow and the JumpList update process should be easier to understand. BUG= 732980 Review-Url: https://codereview.chromium.org/2940743002 Cr-Commit-Position: refs/heads/master@{#480101} [modify] https://crrev.com/78b03b6957876df0bb887486a085cc77c9b52898/chrome/browser/win/jumplist.cc [modify] https://crrev.com/78b03b6957876df0bb887486a085cc77c9b52898/chrome/browser/win/jumplist.h
,
Jun 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 16 2017