New issue
Advanced search Search tips

Issue 732978 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tablet view: When rotation is locked the portrait or landscape indication in system tray is swapped.

Project Member Reported by x...@chromium.org, Jun 13 2017

Issue description

Platform: Chrome OS

See feedback report: https://feedback.corp.google.com/#%2FReport%2F65455270624

when rotation is locked the portrait or landscape indication is swapped.
See screenshot attached as file showing menu saying landscape on a portrait screen.

sammiequon@, could you take a look at it?
 
Screenshot 2017-06-11 at 10.18.15 PM.png
88.0 KB View Download
I can't reproduce this (or view the feedback report), is there anything special the user is doing?

Comment 2 by x...@chromium.org, Jun 15 2017

I didn't see that from the feedback report. Attach the system log for the reference.
system_logs.txt
6.3 MB View Download
Cc: fukino@chromium.org tetsui@chromium.org yhanada@chromium.org
 Issue 733121  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e22da9aabaece8893ca89da7eef10a6d870fed04

commit e22da9aabaece8893ca89da7eef10a6d870fed04
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Jun 23 21:14:39 2017

chromeos: Portrait/landscape indication works with tablets now.

Inidcator now takes into account the natural orientation (portrait for tablets) of the device.

Test: manual
Bug:  732978 
Change-Id: Ie8ce54ac7cf8a70f031268e92e698e2d4589aba5
Reviewed-on: https://chromium-review.googlesource.com/546335
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482033}
[modify] https://crrev.com/e22da9aabaece8893ca89da7eef10a6d870fed04/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/e22da9aabaece8893ca89da7eef10a6d870fed04/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/e22da9aabaece8893ca89da7eef10a6d870fed04/ash/system/rotation/tray_rotation_lock.cc

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment