New issue
Advanced search Search tips

Issue 732977 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Potential memory leak with DocumentStyleSheetCollection::UpdateActiveStyleSheets (GMAIL)

Project Member Reported by etienneb@chromium.org, Jun 13 2017

Issue description

We ran a web browser for a week with memory-infra running (--enable-heap-profiling) and collect some memory dumps. We are using a script to diff the memory allocations based on their stackframe.

We are seeing an increase of remaining objects in the renderer when calling
"blink::Document::UpdateActiveStyle".

Some stackframes are attached to this bug.
 
bug1.png
54.6 KB View Download
bug2.png
74.5 KB View Download
B3.png
76.5 KB View Download
B4.png
68.3 KB View Download
Objects potentially leaked:

85748 + 71464 + 35762  ==> ~192k
Labels: Performance-Memory
Components: Blink>CSS

Comment 4 by r...@opera.com, Aug 21 2017

I don't understand what the claimed leak is and how you measure. The stack traces are all oilpan heap allocations. Do you see an increasing amount of objects from the attached call sites for each UpdateActiveStyleSheets after garbage collecting the oilpan heap?

> We are seeing an increase of remaining objects in the renderer when calling
> "blink::Document::UpdateActiveStyle".

Yes, UpdateActiveStyle does trigger memory allocation for style rule meta data. Can you elaborate on what's unexpected? What do you mean by "remaining objects"?

Labels: Needs-Feedback
Owner: etienneb@chromium.org
Status: Assigned (was: Untriaged)
Labels: Update-Fortnightly
Labels: -Update-Fortnightly

Sign in to add a comment