New issue
Advanced search Search tips

Issue 732973 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 731025
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Top search suggestion from Omnibox has vertical clipping/masking when search term is short

Reported by wyatttt...@gmail.com, Jun 13 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3125.0 Safari/537.36

Steps to reproduce the problem:
1. Type "i" in the Omnibox
2. Delete any autocomplete suggestion so only "i" remains in the Omnibox
3. Note the search suggestion (first result) will be empty. The "i" is fully masked.
4. Type another i so "ii" is in the search bar. You'll notice only the very top of the "ii"s are visible.
5. Repeat with "iii", "iiii", and "iiiii". At five "i"s, no masking occurs.

What is the expected behavior?
The entire search term should be visible, no masking or clipping.

What went wrong?
The bottom portion of the search term is masked vertically, from just a bit of it to the entire search term. This is related to the absolute width of the search, not the character count ("mm" has no masking but "iiii" still does).

Did this work before? Yes 

Chrome version: 61.0.3125.0  Channel: canary
OS Version: OS X 10.10.5
Flash Version:
 
Screen Shot 2017-06-13 at 2.45.27 PM.png
13.9 KB View Download

Comment 1 by ajha@chromium.org, Jun 14 2017

Labels: Needs-Triage-M61 Needs-Bisect
Cc: jmukthavaram@chromium.org
Labels: -Pri-2 -Needs-Bisect -Needs-Triage-M61 hasbisect-per-revision M-61 Pri-1
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.5 using chrome reported version-61.0.3125.0  as per the steps in comment#0.

Good-61.0.3126.0—Revision-478483
Bad-61.0.3125.0— Revision-478135

Providing below reverse bisect info as per new bisect script:
------------------------------------------------------------------
You are probably looking for a change made after 478431 (known good), but no later than 478432 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/1b59498f081885d9f82539f478653669b2c5c5a6..edcd7da1e6157b263551180f0e26c1a826452d53

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/edcd7da1e6157b263551180f0e26c1a826452d53

tommycli@ Could  you please take a look & merge this fix in latest dev build-61.0.3128.0 .

Note: 
1. Unable to repro on Windows 7 & ubuntu 14.04
2. Unable to repro on mac-Dev#61.0.3128.0 & Canary builds#61.0.3131.0

Thanks.

Comment 3 by shrike@chromium.org, Jun 15 2017

Mergedinto: 731025
Status: Duplicate (was: Assigned)
According to  Issue 731025 , this bug was TE-verified fixed in 3128.

Sign in to add a comment