New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732970 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Request Mobile Site feature flag is not visible

Project Member Reported by liaoyuke@chromium.org, Jun 13 2017

Issue description

It turns out there is a typo in the experimental plist file where Default should be DefaultValue.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd6f2dd305dee2674898b6c423ec3035330cc11

commit 2cd6f2dd305dee2674898b6c423ec3035330cc11
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Jun 14 01:25:42 2017

Correct a typo in Experimental_plist.

This CL corrects a typo in Experimental_plist file to make the Request
Mobile Site feature flag visible in the experimental settings on
devices.

Bug:  732970 
Change-Id: Iaca2b53672f4525a3cd0684d1786c9ba2bf8965d
Reviewed-on: https://chromium-review.googlesource.com/534693
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479242}
[modify] https://crrev.com/2cd6f2dd305dee2674898b6c423ec3035330cc11/ios/chrome/browser/resources/Settings.bundle/Experimental.plist

Labels: Merge-Request-60
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 14 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cma...@chromium.org, Jun 14 2017

Labels: -Hotlist-Merge-Review -Merge-Review-60 Merge-Approved-60
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c65204222f88962a03bca7b6fb30a37d63c84f45

commit c65204222f88962a03bca7b6fb30a37d63c84f45
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Jun 14 01:46:09 2017

Correct a typo in Experimental_plist.

This CL corrects a typo in Experimental_plist file to make the Request
Mobile Site feature flag visible in the experimental settings on
devices.

Bug:  732970 
Change-Id: Iaca2b53672f4525a3cd0684d1786c9ba2bf8965d
Reviewed-on: https://chromium-review.googlesource.com/534693
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#479242}(cherry picked from commit 2cd6f2dd305dee2674898b6c423ec3035330cc11)
Review-Url: https://codereview.chromium.org/2937553006 .
Cr-Commit-Position: refs/branch-heads/3112@{#335}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/c65204222f88962a03bca7b6fb30a37d63c84f45/ios/chrome/browser/resources/Settings.bundle/Experimental.plist

Status: Verified (was: Fixed)
Verified in 60.0.3112.34 beta, iPhone 6s plus iOS 10.2.1, iPad mini 10.3 beta 7

Experimental settings "Disable Request Mobile Site" is available.
Thank you for the update!

Sign in to add a comment