New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 732969 link

Starred by 2 users
Status: Fixed
Owner:
pav...@chromium.org
Closed: Jun 2017
Cc:
etienneb@chromium.org
erikc...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Potential memory leak in syncer.

Project Member Reported by erikc...@chromium.org, Jun 13 2017 
I've been looking at sources of browser memory bloat by using native heap profiling on my own browser. Full details:
https://docs.google.com/document/d/1fN5balfyrd7sRpd6DRaUI1TwoOwYjLyRSd7mwZT5US8/edit#

Over the course of 1 week, the browser process created ~12k objects in syncer that it did not destroy.

This is suggestive of a large leak. 

Each screenshot shows:
  1) # of objects created [that have not been destroyed]
  2) The stack trace of the code that created the object.
Screen Shot 2017-06-13 at 2.31.45 PM.png
355 KB View Download
Screen Shot 2017-06-13 at 2.31.52 PM.png
260 KB View Download
Screen Shot 2017-06-13 at 2.32.08 PM.png
279 KB View Download
Screen Shot 2017-06-13 at 2.32.13 PM.png
275 KB View Download
Screen Shot 2017-06-13 at 2.32.19 PM.png
352 KB View Download

Comment 1 by pav...@chromium.org, Jun 13 2017

Owner: pav...@chromium.org

Comment 2 by pav...@chromium.org, Jun 15 2017

Status: Started (was: Untriaged)

Comment 3 by pav...@chromium.org, Jun 15 2017 

Screenshots 2, 3, and 4 are allocations for objects synced with server that sync engine needs to keep in memory. We are working on addressing this with USS project (go/uss-dd)

Screenshots 1 and 5 correspond to entries in FaviconCache that map from page url to favicon url. I posted a change to cleanup this map when favicon is deleted. (http://crrev.com/c/537114)

Comment 4 by etienneb@chromium.org, Jun 19 2017 

see:
  https://bugs.chromium.org/p/chromium/issues/detail?id=734236

Bruce reported a trace with +30k objects.

Comment 5 by pav...@chromium.org, Jun 20 2017

Status: Fixed (was: Started)
Change for FaviconCache was committed: http://crrev.com/c/537114.
►

Sign in to add a comment