New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732958 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

skia roll broke webkit_tests failing on 6 builders

Project Member Reported by dalecur...@chromium.org, Jun 13 2017

Issue description

webkit_tests failing on 6 builders

Builders failed on: 
- WebKit Linux Trusty: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty
- WebKit Linux Trusty Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak
- WebKit Mac10.11: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11
- WebKit Mac10.11 (retina): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29
- WebKit Mac10.12: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12
- WebKit Mac10.9: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9


css3/blending/svg-blend-color.html ( Code Search )
css3/blending/svg-blend-color.html ( Code Search )
css3/blending/svg-blend-hue.html ( Code Search )
css3/blending/svg-blend-hue.html ( Code Search )
css3/blending/svg-blend-luminosity.html ( Code Search )
css3/blending/svg-blend-luminosity.html ( Code Search )
css3/blending/svg-blend-saturation.html ( Code Search )
css3/blending/svg-blend-saturation.html ( Code Search )
 
Verified by manual revert on linux.

Comment 3 by rmis...@google.com, Jun 13 2017

Cc: robertphillips@chromium.org reed@chromium.org
Changes included in the roll:

$ git log e8f28818a..646e4293f --date=short --no-merges --format='%ad %ae %s'
2017-06-13 robertphillips Retract GrTexture*.h & GrRenderTarget*.h from other headers
2017-06-12 benjaminwagner [recipes] Fix internal_test tryjobs.
2017-06-13 rmistry Revert "Add GrPrimitiveType::kLinesAdjacency"
2017-06-13 mtklein ok: add 8888 and rp dsts
2017-06-12 csmartdalton Add GrPrimitiveType::kLinesAdjacency
2017-06-13 reed use pipeline for non-opt xfermodes
2017-06-13 robertphillips Move Flags from GrRenderTarget to GrTypesPriv.h & rename

Any ideas?
I went ahead and stopped the roller
Cc: rmis...@google.com mtklein@chromium.org
Owner: reed@google.com
This is Mike's CL, "2017-06-13 reed use pipeline for non-opt xfermodes".
Labels: -Sheriff-Chromium
Dropping sheriff label since revert landed.

Comment 6 by mtkl...@google.com, Jun 13 2017

I've reverted that CL in Skia and am about to re-start the roll into Chrome.
https://codereview.chromium.org/2936843003/ was supposed to suppress these failures.

Comment 8 by mtkl...@google.com, Jun 13 2017

That's weird.  Did we suppress them wrong?
I suspect something went wrong with converting them from being compared against the results of another html file rendering and being compared to a stored image.

So, yeah, but I don't know what went wrong.

Comment 10 by reed@google.com, Jun 13 2017

Cc: fmalita@chromium.org

Comment 11 by reed@google.com, Jun 13 2017

Looks there are now images (png) for those tests. Perhaps I just re-mark those for needsmanualrebaseline, now that they are images and not html
Labels: Sheriff-Chromium Pri-1 Type-Bug-Regression
This is now failing again after the roll, but this time on Windows:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10064
https://chromium.googlesource.com/chromium/src/+/e635c3f42d2634a3335fea3671efeb95b3b898da

Please revert or update the suppressions for those tests.
Labels: -Pri-1 -Sheriff-Chromium Pri-2
Actually, nevermind, it seems fixed in latest builds. I was looking at an earlier one. Sorry for the noise!
Owner: reed@chromium.org
Owner: reed@google.com
Status: Fixed (was: Assigned)

Sign in to add a comment