Issue metadata
Sign in to add a comment
|
skia roll broke webkit_tests failing on 6 builders |
||||||||||||||||||||||
Issue descriptionwebkit_tests failing on 6 builders Builders failed on: - WebKit Linux Trusty: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty - WebKit Linux Trusty Leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak - WebKit Mac10.11: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11 - WebKit Mac10.11 (retina): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 - WebKit Mac10.12: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12 - WebKit Mac10.9: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9 css3/blending/svg-blend-color.html ( Code Search ) css3/blending/svg-blend-color.html ( Code Search ) css3/blending/svg-blend-hue.html ( Code Search ) css3/blending/svg-blend-hue.html ( Code Search ) css3/blending/svg-blend-luminosity.html ( Code Search ) css3/blending/svg-blend-luminosity.html ( Code Search ) css3/blending/svg-blend-saturation.html ( Code Search ) css3/blending/svg-blend-saturation.html ( Code Search )
,
Jun 13 2017
,
Jun 13 2017
Changes included in the roll: $ git log e8f28818a..646e4293f --date=short --no-merges --format='%ad %ae %s' 2017-06-13 robertphillips Retract GrTexture*.h & GrRenderTarget*.h from other headers 2017-06-12 benjaminwagner [recipes] Fix internal_test tryjobs. 2017-06-13 rmistry Revert "Add GrPrimitiveType::kLinesAdjacency" 2017-06-13 mtklein ok: add 8888 and rp dsts 2017-06-12 csmartdalton Add GrPrimitiveType::kLinesAdjacency 2017-06-13 reed use pipeline for non-opt xfermodes 2017-06-13 robertphillips Move Flags from GrRenderTarget to GrTypesPriv.h & rename Any ideas? I went ahead and stopped the roller
,
Jun 13 2017
This is Mike's CL, "2017-06-13 reed use pipeline for non-opt xfermodes".
,
Jun 13 2017
Dropping sheriff label since revert landed.
,
Jun 13 2017
I've reverted that CL in Skia and am about to re-start the roll into Chrome.
,
Jun 13 2017
https://codereview.chromium.org/2936843003/ was supposed to suppress these failures.
,
Jun 13 2017
That's weird. Did we suppress them wrong?
,
Jun 13 2017
I suspect something went wrong with converting them from being compared against the results of another html file rendering and being compared to a stored image. So, yeah, but I don't know what went wrong.
,
Jun 13 2017
,
Jun 13 2017
Looks there are now images (png) for those tests. Perhaps I just re-mark those for needsmanualrebaseline, now that they are images and not html
,
Jun 14 2017
This is now failing again after the roll, but this time on Windows: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10064 https://chromium.googlesource.com/chromium/src/+/e635c3f42d2634a3335fea3671efeb95b3b898da Please revert or update the suppressions for those tests.
,
Jun 14 2017
Actually, nevermind, it seems fixed in latest builds. I was looking at an earlier one. Sorry for the noise!
,
Aug 2
,
Jan 16
,
Jan 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Jun 13 2017