Download link automatically pauses |
||
Issue descriptionChrome Version: Tip of tree 61.0.3129.0 OS: Android L What steps will reproduce the problem? (1) Use long press and "Download Link" on the following link https://twitter.com/Respawn/status/873944104996003844?ref_src-twsrc^tfw&ref_url=http:// (2) The above link was seen in the BluesNews.com news article "Titanfall 2 Free Week" in the news for Jun 12 2017. What is the expected result? Page downloaded, or at the very least it would restart when I hit the restart button. What happens instead? We get a notification, and the download pauses. If I choose "restart", it pauses again right away. Notification says: 873944104996003844 ------------------------------- Download paused <down arrow> Resume <Big X> Cancel This seems to have some similarities to crbug.com/714798 , which is marked fixed.
,
Jun 13 2017
Can we do better than that on android? I have seen notifications saying "Download failed" when we do it for Offline Pages, so I know it is possible to display failure to the user.
,
Jun 13 2017
Download interrupted currently are considered as resumable, so we show a pause button instead of failed. It is probably better to differentiate notifications between non-auto resumable interrupted download and paused download. Jon, WDYT of treating the notification text differently between non-auto-resumable interrupted downloads vs. paused downloads?
,
Jun 13 2017
Out of curiosity: what is the server missing such that this is not going to offline pages code at all? You mention it's interrupted because of a server problem - what kind of server problem?
,
Jun 13 2017
offline page requires server response header contains text/html, which is not the case for the above link. I am not sure what the actual http response code is. But when saving the link on desktop, i got the server problem error. And net-export doesn't capture logs from context menu link savings, so I need to build chrome to check out what is the actual http response code.
,
Jun 14 2017
I see. The page returns a 400 bad request error on desktop. The response header does not contain a content-type parameter, which is most likely why the download is auto-pausing. Offline pages will fail the download attempt whenever we encounter http error (and auto-resume later). Perhaps we should add code for a similar experience in downloads regardless of content-type header? e.g. if we get an http error, put it back in pending state and try again later and/or simply fail the download?
,
Jun 14 2017
In the case where the download really cannot complete, such as this, we should just go ahead and fail the download. Using the download paused notification will confuse users. A pending state with a later auto-resume could work, but again, we need to somehow explain to users why their content isn't downloading and may not for 24 hours. |
||
►
Sign in to add a comment |
||
Comment 1 by qin...@chromium.org
, Jun 13 2017