New issue
Advanced search Search tips

Issue 732925 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue gerrit:6441
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Gerrit doesn't handle similarity detection as well as Rietveld

Project Member Reported by michae...@chromium.org, Jun 13 2017

Issue description

Gerrit doesn't seem to work as well as Rietveld in detecting similarity between moved files in general. Is that a known issue?

Here's a specific case which is a little complicated:

I created a patch which took a .h file and a .cc file, split each one into two files, and moved them. Each pair of new files shares some code from the file they spawned from.

So the deleted files[1] were split into two sets of new files[2].

With `git cl upload --similarity=10 --rietveld`: [3]
Rietveld successfully finds the similarities between all four new files from [2] and the removed files from [1].

With `git cl upload --similarity=10 --gerrit`: [4]
Gerrit only finds the similarities between the deleted files and one set of the new files. It also marks those NEW files as "R"! The other set of new files are shown just as "A" and the diff shows the entire file as added lines.


[1] Deleted files:
    chrome/browser/extensions/api/file_system/file_system_api.cc
    chrome/browser/extensions/api/file_system/file_system_api.h
[2] New files:
    chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
    chrome/browser/extensions/api/file_system/chrome_file_system_delegate.h
    extensions/browser/api/file_system/file_system_api.cc
    extensions/browser/api/file_system/file_system_api.h
[3] https://codereview.chromium.org/2937753002/#ps1
[4] https://chromium-review.googlesource.com/c/531757/5
 

Comment 1 by aga...@chromium.org, Jun 13 2017

Mergedinto: gerrit:6441
Status: Duplicate (was: Unconfirmed)
Yep, this is a known issue, and one that we're trying to get the gerrit folks to fine-tune at the highest priority after launch.

Sign in to add a comment