New issue
Advanced search Search tips

Issue 732921 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 738886
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Critical update message is misaligned on sign-in screen

Project Member Reported by sdantul...@chromium.org, Jun 13 2017

Issue description

Google Chrome	61.0.3129.0 (Official Build) dev (64-bit)
Revision	0
Platform	9647.0.0 (Official Build) dev-channel cyan

What steps will reproduce the problem?
1. Update device from M59 to M61 to see critical update available message on sign-in screen

What happens?
Critical update message is not aligned properly.

Attached screenshot.
 
D642FE2B-27E0-4D6E-B336-EAA0E78C418D.JPG
2.5 MB View Download

Comment 1 by wzang@chromium.org, Jun 13 2017

Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by r...@chromium.org, Jun 13 2017

Cc: jdufault@chromium.org
Please keep jdufault@ cc'ed on all login/lockscreen bugs. He is TLing the lockscreen redesign.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9

commit 27848b1c4ddb114bf2462ba8c6d46d9b49f489b9
Author: wzang <wzang@chromium.org>
Date: Fri Jun 16 02:04:44 2017

Fix misplacement of signin overlay and critical update message banner

This CL combines several small changes:

1) Fix  crbug.com/732921  by using offsetWidth instead of a fixed width
value when positioning.

2) Fix  crbug.com/732683  by combining .user-image and .pod classes. The
oobe container has another class also named as .user-image so they
interfere with each other.

3) CSS style changes, including ones for easy unlock icon
(updating assets is done by CL 2934193002) and removing the sign-in
badge per the new spec.

4) Correct tab order for public session pods, also make sure that the
focus correctly goes to other small pods after leaving the public pod,
by changing display:none to opacity:0.

5) Update border style for reset screen (capturing CL 2879593005)

BUG= 732921 ,  732683 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2936173002
Cr-Commit-Position: refs/heads/master@{#479921}

[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_template.html
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/md_screen_container.css

Comment 4 by wzang@chromium.org, Jun 16 2017

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Update message is still looks off center.

Attached screenshot.
EE1D8017-FEEA-4769-9D56-5278C3654BA9.JPG
2.7 MB View Download
c#5 is on ChromeOS 9737.0.0, 61.0.3154.0

Comment 7 by wzang@chromium.org, Jul 13 2017

Cc: sdantul...@chromium.org
I can't repo it on ToT. Are there more detailed repo steps?
IMG_20170712_164728.jpg
2.7 MB View Download
Just noticed that this is not seen always.

Repro steps:
1. Reboot device and check sign-in screen. Update message is off center.
2. Click on Add person button from shelf.
3. Close the login dialog by clicking 'x' button
4. Update message is aligned properly now.
5. Login to user account and log-out
6.  Update message is off center again.


Comment 9 by wzang@chromium.org, Jul 17 2017

Mergedinto: 738886
Status: Duplicate (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ccdec6a10d35aa9d6e64994905748ca23d1404

commit 45ccdec6a10d35aa9d6e64994905748ca23d1404
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Jul 24 23:24:48 2017

Update sign in banner position at WebUI login screen

Update banner position right after message update because
|showBannerMessage| may be called after pod placement is done.

Other nonessential changes include adjusting ripple position, hide
scroll bar and error bubbles.

Bug:  732921 
Change-Id: I663517143727628ba94b7ac6a5ca555dbba1d65b
Reviewed-on: https://chromium-review.googlesource.com/571059
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489137}
[modify] https://crrev.com/45ccdec6a10d35aa9d6e64994905748ca23d1404/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html
[modify] https://crrev.com/45ccdec6a10d35aa9d6e64994905748ca23d1404/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/45ccdec6a10d35aa9d6e64994905748ca23d1404/ui/login/account_picker/md_user_pod_row.js

Labels: Merge-Request-61
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf47df4b1f523323a3ddbc958c5edc7068844a6

commit cbf47df4b1f523323a3ddbc958c5edc7068844a6
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 00:36:07 2017

Update sign in banner position at WebUI login screen

Update banner position right after message update because
|showBannerMessage| may be called after pod placement is done.

Other nonessential changes include adjusting ripple position, hide
scroll bar and error bubbles.

TBR=wzang@chromium.org

(cherry picked from commit 45ccdec6a10d35aa9d6e64994905748ca23d1404)

Bug:  732921 
Change-Id: I663517143727628ba94b7ac6a5ca555dbba1d65b
Reviewed-on: https://chromium-review.googlesource.com/571059
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489137}
Reviewed-on: https://chromium-review.googlesource.com/609274
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#420}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/cbf47df4b1f523323a3ddbc958c5edc7068844a6/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html
[modify] https://crrev.com/cbf47df4b1f523323a3ddbc958c5edc7068844a6/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/cbf47df4b1f523323a3ddbc958c5edc7068844a6/ui/login/account_picker/md_user_pod_row.js

Sign in to add a comment