VR: Send separate down/up events for controller touchpad clicks. |
|||
Issue descriptionWe should be sending down/up events separately to allow selection, drawing, etc. Now that we've disabled popups, this shouldn't cause crashes/show 2D UI.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a36d1978df99e98cf8696c5824bb8050f514928 commit 2a36d1978df99e98cf8696c5824bb8050f514928 Author: mthiesse <mthiesse@chromium.org> Date: Wed Jun 14 16:00:14 2017 VR: Add support for mouse down/up events for Android NativePages. BUG= 732917 Review-Url: https://codereview.chromium.org/2942623002 Cr-Commit-Position: refs/heads/master@{#479402} [modify] https://crrev.com/2a36d1978df99e98cf8696c5824bb8050f514928/chrome/browser/android/vr_shell/android_ui_gesture_target.cc
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2acdcced51403c0b6d0ed515f0e86d432a901839 commit 2acdcced51403c0b6d0ed515f0e86d432a901839 Author: mthiesse <mthiesse@chromium.org> Date: Thu Jun 15 15:56:36 2017 VR: Stop sending mouse moves while mouse is down to content window. The VR controller is way too noisy/sensitive and triggers drag events when you're trying to click links. As a temporary workaround, stop sending move events to the content window when the 'mouse' is down. BUG= 732917 Review-Url: https://codereview.chromium.org/2944453002 Cr-Commit-Position: refs/heads/master@{#479720} [modify] https://crrev.com/2acdcced51403c0b6d0ed515f0e86d432a901839/chrome/browser/android/vr_shell/vr_shell_gl.cc
,
Jun 20 2017
Am I understand right, that neither selection nor drawing with the controller are still not supported in ChromeVR?
,
Jun 20 2017
That's right, we had to prevent selection and drawing for now.
,
Jun 20 2017
,
Jun 23 2017
Verified in Chrome Canary 61.0.3138.0 |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2017