New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732904 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Check canvas color correction pipeline to be HDR

Project Member Reported by zakerinasab@chromium.org, Jun 13 2017

Issue description

The color correction pipeline in canvas should not clip the HDR values. The compositor will take care of clipping if necessary.
 
Blocking: 634542
Cc: -junov@chromium.org
Cc: fs...@chromium.org
There is no explicit clipping anywhere in canvas code. Color conversion may cause clipping if the destination gamut does not support HDR values. Other than that, some API like getImageData (when returning uint8 or unit16 array) do clip by definition.
We have HDR test for ImageData in third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-e_srgb.html. What remains for now is to add a proper HDR test to third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-e_srgb.html.
And may be drawing a canvas on canvas. In fact it might be better to add a layout test specifically to test HDR, covering:

- drawImage for canvas and OffscreenCanvas
- createImageBitmap
- convertToBlob
- get/putImageData

Sign in to add a comment