Compile Failure on official.desktop.continuous BETA builder -Win64,Mac and Linux |
||||
Issue descriptionLink to Builder =============== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/398 Link to Log File ================= https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/398/steps/compile/logs/stdio Error Log ========== c:\b\c\b\win64_beta\src\chrome\browser\ui\views\payments\payment_sheet_view_controller.cc(585): error C3861: 'CreateHintLabel': identifier not found c:\b\c\b\win64_beta\src\chrome\browser\ui\views\payments\payment_sheet_view_controller.cc(590): error C3861: 'CreateHintLabel': identifier not found Possible suspect ================ https://chromium.googlesource.com/chromium/src.git/+/cd5d606a416e2809a76dbd055bd1ffec00d32af8 Anthony , please take a look at this failure ASAP as its blocking today's Beta RC cut planned at 4.00 PM PST.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea3ed77b57e037e2beb39edcb168c8c3a9172c9 commit dea3ed77b57e037e2beb39edcb168c8c3a9172c9 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Tue Jun 13 20:10:19 2017 Revert "Merge - [Web Payments] Payment Sheet UI fixes" This reverts commit cd5d606a416e2809a76dbd055bd1ffec00d32af8. TBR=anthonyvd@chromium.org,mathp@chromium.org Bug: 732887 Change-Id: Ifbb0e120da5200fdc8eb502f8f0eb0d650ed3331 Reviewed-on: https://chromium-review.googlesource.com/533643 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#325} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/dea3ed77b57e037e2beb39edcb168c8c3a9172c9/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/dea3ed77b57e037e2beb39edcb168c8c3a9172c9/components/payments_strings.grdp
,
Jun 13 2017
This should be fixed now.
,
Jun 14 2017
There are no recent failures on Beta with this specific error log on Windows,Mac & Linux. Hence adding the verified label for M-60. Builders link: ============== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/411 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/435 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/590 |
||||
►
Sign in to add a comment |
||||
Comment 1 by ligim...@chromium.org
, Jun 13 2017Labels: Sheriff-Chromium