New issue
Advanced search Search tips

Issue 732873 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Potential memory leak in AdsPageLoadMetricsObserver::OnDidFinishSubFrameNavigation.

Project Member Reported by erikc...@chromium.org, Jun 13 2017

Issue description

I've been looking at sources of browser memory bloat by using native heap profiling on my own browser. Full details:
https://docs.google.com/document/d/1fN5balfyrd7sRpd6DRaUI1TwoOwYjLyRSd7mwZT5US8/edit#

Over the course of 1 week, the browser process created ~18k objects in AdsPageLoadMetricsObserver::OnDidFinishSubFrameNavigation() that it did not destroy. This is suggestive of a large leak.

Each screenshot shows:
  1) # of objects created [that have not been destroyed]
  2) The stack trace of the code that created the object.

jkarlin: Can you take a look?
 
Screen Shot 2017-06-13 at 10.46.22 AM.png
288 KB View Download
Thanks for the report. One object is created per frame and is held until the page is navigated away from. So if the page is producing 18,000 frames during its lifetime then we've got a problem. I can probably take care of this by deleting the objects on frame destruction, though I'll need to keep some of them (those that contained ads) around.

Sign in to add a comment