macOS sab tab is implemented in Objective c++ in chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm which has not had the required changes to support the bulleted lists.

I don't know objective C++ so I'm probably not the best person to implement this code. We should either find someone to do this, and/or change the code to at least not display the "try the following tips" until the bullet code can be added.

Perhaps peterlaurens or sdy have ideas here? If nobody else can take it I can just stumble around in objc++ and try and guess the syntax to try and get something done - it seems to have a lot of square brackets, and I don't think they are arrays.

Perhaps sdy@ (once he's mostly done with the md downloads bar).

Sure, since I know this code.

@sdy thanks! the code to generate the bullets in views is here -> https://cs.chromium.org/chromium/src/chrome/browser/ui/views/sad_tab_view.cc?q=sad_tab_view.cc you just call GetSubMessage in a loop until you get 0 back.

I was thinking if the sad tab used macviews then would this issue go away?

In case it helps, the iOS code is:

https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm?q=sad_tab_view.mm&dr

... there are some interesting methods in there for concatenating lists of bullets, and for using paragraph styles to properly align the text in a textview. Should apply maybe with some tweaking to macOS.

How does this look to everyone?

wfh@: You're right that MacViews would fix this. AFAIK, it can only be used for whole windows. So, bubbles, dialogs, etc. are OK, but not UI in the main window (as long as the main window is Cocoa).

Deleted: Screen Shot 2017-06-16 at 7.46.47 PM.png 177 KB

	Screen Shot 2017-06-16 at 7.46.47 PM.png 177 KB View Download

That looks great. And just confirming that that's the view with other tabs open. With no tabs open the first bullet should only say: "close other apps"

Yep! There was another window open when I took the screenshot.

CL is up: https://crrev.com/c/538220

 Issue 726249  has been merged into this issue.

This looks great in Canary - just tested it today. Can we request a merge into 60?

It looks like I broke it slightly — fixing it now! Then, sure.

Requesting a merge for r480509 and r480890.

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+Mano to coordinate TE verification

Tested the issue on Mac OS 10.12.5 using chrome latest Canary M61-61.0.3138.0 by following steps mentioned in the original comment. Observed that issue seems to be fixed but different behaviour observed in chrome://crash page.Please find the screen casts for reference.

Note:If user types fast in ominibox bad page("Can't open this page") is displayed and user types slowly in ominibox bad page("Aw, Snap!") is displayed.

@sdy : Could you please let me know if i have missed anything, which would help us to verify the issue further.

Thanks in Advance.

Deleted: 732864(Working fine).mp4 1.1 MB

	732864(Working fine).mp4 1.1 MB View Download

Deleted: 732864(Observations).mp4 1.0 MB

	732864(Observations).mp4 1.0 MB View Download

rbasuvula@: The "Can't open this page" version with the bullets is only shown if there are two crashes within 10 seconds. Your screencasts look right to me.

Thanks for immediate feedback.As per comment #21 & 22 Observed that Try the following tips are displaying as expected. Hence adding TE-Verified label.

Thank You!

Verified fix by TE. Approving merge to M60. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6c6c7d92389956c5894ea7b30012cb527cbd66

commit 0d6c6c7d92389956c5894ea7b30012cb527cbd66
Author: Sidney San Martín <sdy@chromium.org>
Date: Fri Jun 23 20:46:17 2017

Show suggestions on the Mac Sad Tab.

Already implemented on other platforms (crbug.com/697259).

TBR=sdy@chromium.org

(cherry picked from commit 34309956ae5a711ae2e1006fe4f5a6dea34bcfc4)

Bug:  732864 
Change-Id: I6ca9f742b3b41f49d21e1537dd5f566abf29662a
Reviewed-on: https://chromium-review.googlesource.com/538220
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martin <sdy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480509}
Reviewed-on: https://chromium-review.googlesource.com/546138
Reviewed-by: Sidney San Martin <sdy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#450}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/0d6c6c7d92389956c5894ea7b30012cb527cbd66/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

Verified the fix on Mac 10.12.5 using Chrome beta version #60.0.3112.50 as per the comment #0.
Attaching screen cast for reference.
Observed a bullet list of tips after "Try the following tips:" as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

Deleted: 732864.mp4 562 KB

	732864.mp4 562 KB View Download