[Autofill] Backspace isn't considered as UserGesture |
||||||||||||
Issue descriptionIn Android, WebUserGestureIndicator::IsProcessingUserGesture() returns false when backspace is entered. This at least make autofill/autocomplete not work properly. The scenario is - Uses chrome android browser to navigate a login page (like amazon login page), if the email/password autofilled, clear the textfield. - Enter a valid email address, you might be prompted more than one suggestions like a@gmail.com ab@gmail.com - enter 'ab', only ab@gmail.com will show as suggestion - type backspace, the text field value is 'a', but only ab@gmail.com is shown as suggestion. Expected behavior: both a@gmail.com, ab@gmail.com should be shown as suggestions. It because autofill agent doesn't think typing backspace is user gesture because WebUserGestureIndicator::IsProcessingUserGesture() returns false.
,
Jun 13 2017
Hmm.. I just briefly looked at WebInputMethodControllerImpl.cpp implementation which keeps track of user gesture through RAII design pattern of UserGestureIndicator[1], but it does not cover the whole IME commands such as SetCompositionFromExistingText() / DeleteSurroundingText(). Google English/Latin Keyboard these days use a bit more complicated deletion steps. That can be confirmed if this issue does not repro with Samsung keyboard. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp?type=cs&l=71 cc'ing ekaramad@ FYI
,
Jun 15 2017
,
Jun 22 2017
I think it is reasonable to set the user gesture flag in these IME composition methods. eirage@ can you work with mustaq's guidance how to set them?
,
Jun 22 2017
,
Jun 22 2017
Agreed. There are many missing places in the code where we should be setting user gesture flag but are not, because we never made a systematic triage.
,
Sep 27 2017
,
Nov 1 2017
,
May 1 2018
,
May 9 2018
,
May 31 2018
,
Jun 6 2018
,
Jun 6 2018
(I meant to un-assign myself but somehow clear the status :) Mustaq will take over this one :) |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by michaelbai@chromium.org
, Jun 13 2017