New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732852 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5%-15.7% regression in system_health.memory_desktop at 477557:477799

Project Member Reported by erikc...@chromium.org, Jun 13 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2017


=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_media/load_media_youtube


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.youtube system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976884503248418336

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5280654150860800


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: sullivan@chromium.org nednguyen@chromium.org
"Bisect failed for unknown reasons"
Cc: simonhatch@chromium.org
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

Cc: danakj@chromium.org
Owner: danakj@chromium.org

=== Auto-CCing suspected CL author danakj@chromium.org ===

Hi danakj@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : danakj
  Commit : f4730d5033656a932a06a3d6465fd3be9591b9c3
  Date   : Wed Jun 07 15:30:30 2017
  Subject: cc: Make DisplayItemList hold a single PaintOpBuffer directly.

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_media/load_media_youtube
  Change       : 15.37% | 123850665.333 -> 142408276.0

Revision             Result                     N
chromium@477612      123850665 +- 13862220      9       good
chromium@477636      122206804 +- 5523279       6       good
chromium@477648      124648020 +- 4314191       6       good
chromium@477654      124631636 +- 4403792       6       good
chromium@477657      120617556 +- 21675976      6       good
chromium@477658      139409251 +- 4439959       6       bad       <--
chromium@477659      145128020 +- 6886427       6       bad
chromium@477706      138185563 +- 34687171      14      bad
chromium@477799      142408276 +- 7222501       9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.youtube system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976879753678205216

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5280654150860800


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 8 by danakj@chromium.org, Jun 13 2017

Cc: vmp...@chromium.org enne@chromium.org

Comment 9 by danakj@chromium.org, Jun 13 2017

r479057 will probably recover this
Labels: -Performance-Memory Performance-Sheriff
Status: WontFix (was: Untriaged)
This recovered.

Sign in to add a comment