New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732848 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

76.4%-146.8% regression in system_health.memory_desktop at 474059:474242

Project Member Reported by erikc...@chromium.org, Jun 13 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=732848

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg5qDKpwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxonjpwsM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
chromium-rel-mac11-air
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2017


=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_social/browse_social_twitter


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.twitter system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976885077180494624

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5850670063681536


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: sullivan@chromium.org nednguyen@chromium.org
"Bisect failed for unknown reasons"
Cc: simonhatch@chromium.org
+Simon: what does "Bisect failed for unknown reasons" usually mean?
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 13 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_social/browse_social_twitter

Revision             Result                   N
chromium@474058      8372434 +- 16811540      21      good
chromium@474165      7109605 +- 11917214      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.twitter system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976879731912737376

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5850670063681536


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Right now it's a catch all for any error we don't handle, ie. recipe error, bot restart, test made bot go purple, etc.

In this case, kind of looks like there was a master restart around then, I see multiple bots all going down at exactly yesterday at 10am.
Labels: -Performance-Memory Performance-Sheriff
Probably too late to catch this, but the regression could have occurred across a pretty big range. Kicking a bisect on a broader range.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

Cc: nedngu...@google.com
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author nednguyen@google.com ===

Hi nednguyen@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : nednguyen
  Commit : 0ebf7116bec925d8d6dd90b5760953ad5be6a383
  Date   : Wed May 24 09:56:02 2017
  Subject: Rerecord browse:social:twitter story & reenable the story

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_social/browse_social_twitter
  Change       : 95.00% | 6055987.14286 -> 12188893.2857

Revision             Result                   N
chromium@473727      6055987 +- 7820062       14      good
chromium@474026      9219812 +- 15576834      21      good
chromium@474176      8099417 +- 9206407       9       good
chromium@474214      8268590 +- 7667107       9       good
chromium@474224      7889299 +- 9718780       13      good
chromium@474229      8314346 +- 8491216       9       good
chromium@474231      7863208 +- 11375717      13      good
chromium@474232      12321304 +- 2432473      9       bad       <--
chromium@474233      12431487 +- 1551649      9       bad
chromium@474251      12392683 +- 2203008      9       bad
chromium@474325      12188893 +- 3281550      14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.twitter system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970983554453234720


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
This is a test change, so regression is expected & benign. 

Sign in to add a comment