The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a55316f4e790fb3337f81cb37a5871b7b8f7f308

commit a55316f4e790fb3337f81cb37a5871b7b8f7f308
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jun 23 16:02:49 2017

Foundation for recording UKMs for the Password Manager

Bug: 732846
Change-Id: I12291bfc4484a11cd068a50fd3603525d6577c18
Reviewed-on: https://chromium-review.googlesource.com/533217
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481910}
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/components/ukm/public/ukm_recorder.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/a55316f4e790fb3337f81cb37a5871b7b8f7f308/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b

commit cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jul 03 09:13:16 2017

Record UKMs for suppressed accounts

Bug: 732846
Change-Id: Ic1ce9ba28a875736cdfe3f163b8d833d27bec5b7
Reviewed-on: https://chromium-review.googlesource.com/546355
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483966}
[modify] https://crrev.com/cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdee64918b87ca44ced10d16434a3a291cc10c9f

commit fdee64918b87ca44ced10d16434a3a291cc10c9f
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jul 03 11:40:07 2017

Record UKMs of users typing into password forms.

Bug: 732846
Change-Id: Ic3c30978f2a32b62bc1a320edb512f279cebedf8
Reviewed-on: https://chromium-review.googlesource.com/550216
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483989}
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/chrome/renderer/autofill/fake_content_password_manager_driver.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/chrome/renderer/autofill/fake_content_password_manager_driver.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/autofill/content/common/autofill_driver.mojom
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/content/browser/content_password_manager_driver.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/password_manager_client.h
[add] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[add] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/password_manager_metrics_recorder.h
[add] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/components/ukm/public/ukm_recorder.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/fdee64918b87ca44ced10d16434a3a291cc10c9f/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a994d09242441a18faf5bbf6554ac7d82faa064

commit 5a994d09242441a18faf5bbf6554ac7d82faa064
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jul 03 15:42:39 2017

Move RecordFailure into PasswordManagerMetricsRecorder

This CL moves PasswordManager::RecordFailure into
PasswordManagerMetricsRecorder. This is a precursor to recording the metrics as
UKMs.

Bug: 732846
Change-Id: I91d803e27dd12d04e20bcc3e21a1a14caa706640
Reviewed-on: https://chromium-review.googlesource.com/558353
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484008}
[modify] https://crrev.com/5a994d09242441a18faf5bbf6554ac7d82faa064/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/5a994d09242441a18faf5bbf6554ac7d82faa064/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/5a994d09242441a18faf5bbf6554ac7d82faa064/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/5a994d09242441a18faf5bbf6554ac7d82faa064/components/password_manager/core/browser/password_manager_metrics_recorder.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359fd712f356c559424b0eeefb925c9c7e25b33e

commit 359fd712f356c559424b0eeefb925c9c7e25b33e
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 13 07:02:17 2017

Record UKMs for filling events of the password manager

Bug: 732846
Change-Id: I5aec47b252a086f6ab7d0344d60d93fe76260e85
Reviewed-on: https://chromium-review.googlesource.com/567147
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486300}
[modify] https://crrev.com/359fd712f356c559424b0eeefb925c9c7e25b33e/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/359fd712f356c559424b0eeefb925c9c7e25b33e/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/359fd712f356c559424b0eeefb925c9c7e25b33e/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/359fd712f356c559424b0eeefb925c9c7e25b33e/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/359fd712f356c559424b0eeefb925c9c7e25b33e/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51dee544f29aab0c3bba2c21d763d379187e8195

commit 51dee544f29aab0c3bba2c21d763d379187e8195
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jul 14 07:42:53 2017

UKMs for password save/update bubbles

This CL introduces measuring the events that save/update bubbles are triggered
and reasons why save/update bubbles are dismissed.

NOTRY=true

Bug: 732846
Change-Id: I885985e0ffcd610af8c2f0a1d55824d63330b43f
Reviewed-on: https://chromium-review.googlesource.com/565286
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486699}
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/password_manager/update_password_infobar_delegate_android.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/passwords_model_delegate.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/chrome/browser/ui/passwords/passwords_model_delegate_mock.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/credential_manager_password_form_manager.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/credential_manager_password_form_manager.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/51dee544f29aab0c3bba2c21d763d379187e8195/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc67cf8f43a0f76dec8dc56266fa086316e6779

commit ffc67cf8f43a0f76dec8dc56266fa086316e6779
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jul 14 08:01:36 2017

Remove 'internal' namespace from ukm name constants

Bug: 732846
Change-Id: I56baa3c06e6eb77da4d47432c48fb7751f9d6394
Reviewed-on: https://chromium-review.googlesource.com/570160
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486703}
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_manager_metrics_recorder.h
[modify] https://crrev.com/ffc67cf8f43a0f76dec8dc56266fa086316e6779/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9e5af6d4c57aa7ec05e98db4c781561bd136fd3

commit a9e5af6d4c57aa7ec05e98db4c781561bd136fd3
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jul 14 11:05:25 2017

Replace constexpr char[] with extern const char[] in header

Replace constexpr char[] with extern const char[] in header because we are
unsure whether the former does the right thing or whether there is a risk of
unnecessary overhead.

NOTRY=true

Bug: 732846
Change-Id: Ic328d6568325072cef6ab7b9b9b0ce36bb587cb0
Reviewed-on: https://chromium-review.googlesource.com/571747
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486728}
[modify] https://crrev.com/a9e5af6d4c57aa7ec05e98db4c781561bd136fd3/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/a9e5af6d4c57aa7ec05e98db4c781561bd136fd3/components/password_manager/core/browser/password_form_metrics_recorder.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/676f55544bc2a1d6e4e2728ffd2ec943d62bcf39

commit 676f55544bc2a1d6e4e2728ffd2ec943d62bcf39
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jul 14 15:45:05 2017

Introduce User.ActionSimplified UKM metric

This CL introduces a new UKM metric User.ActionSimplified that corresponds to
what is recorded in PasswordManagerActionsV3. I have called it ActionSimplified
because I want to introduce a more detailed action but don't know whether I can
build that before the branch point.

Bug: 732846
Change-Id: I766ec456de100e93b61a63c0ede6fd65dbd36156
Reviewed-on: https://chromium-review.googlesource.com/571003
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486765}
[modify] https://crrev.com/676f55544bc2a1d6e4e2728ffd2ec943d62bcf39/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/676f55544bc2a1d6e4e2728ffd2ec943d62bcf39/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/676f55544bc2a1d6e4e2728ffd2ec943d62bcf39/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/676f55544bc2a1d6e4e2728ffd2ec943d62bcf39/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79eb827de6b9659e8116d93e7665f76c22edd2f8

commit 79eb827de6b9659e8116d93e7665f76c22edd2f8
Author: Dominic Battre <battre@chromium.org>
Date: Fri Jul 14 17:04:56 2017

Allow consecutive password bubbles

The PasswordFormMetricsRecorder enforced that a single save/update bubble was
shown to users. With manual fallbacks, this restriction is too strong.
Therefore, this CL introduces an enum that tracks the currently displayed
bubble, which is enough to attribute dismissal reasons to update/save bubbles.

Bug: 732846
Change-Id: I84377c4416962dfd0ed1f3e4e601aaa9f87bd042
Reviewed-on: https://chromium-review.googlesource.com/571005
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486785}
[modify] https://crrev.com/79eb827de6b9659e8116d93e7665f76c22edd2f8/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/79eb827de6b9659e8116d93e7665f76c22edd2f8/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/79eb827de6b9659e8116d93e7665f76c22edd2f8/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8eecbee41760323ec374f16aba09c0d839791b

commit ed8eecbee41760323ec374f16aba09c0d839791b
Author: Dominic Battre <battre@chromium.org>
Date: Wed Jul 19 15:00:03 2017

Implement User.Action UKM metric for password manager.

This CL introduces a metric that records how users interact with forms and
password manager UI. In contrast to User.ActionSimplified, this metric will
grow with new interactions.

Bug: 732846
Change-Id: I97d02d5f5afa4a5e68e214c1bc1e20d1580e0e25
Reviewed-on: https://chromium-review.googlesource.com/574712
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487867}
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/components/ukm/test_ukm_recorder.cc
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/components/ukm/test_ukm_recorder.h
[modify] https://crrev.com/ed8eecbee41760323ec374f16aba09c0d839791b/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d904bbaae43c904a030c937d607913c76c386f06

commit d904bbaae43c904a030c937d607913c76c386f06
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 20 09:22:01 2017

Record UKMs for failing to provisionally save a password form

Bug: 732846
Change-Id: I011b4805a15501df0fb32ac3fd6002e44a56d9c2
Reviewed-on: https://chromium-review.googlesource.com/575242
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488173}
[modify] https://crrev.com/d904bbaae43c904a030c937d607913c76c386f06/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/d904bbaae43c904a030c937d607913c76c386f06/components/password_manager/core/browser/password_manager_metrics_recorder.h
[modify] https://crrev.com/d904bbaae43c904a030c937d607913c76c386f06/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc9d281b4bd298555bcbc112e2911a3d4a67959

commit 9dc9d281b4bd298555bcbc112e2911a3d4a67959
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 20 10:59:30 2017

Delay binding of SourceId to URL in PasswordManagerMetricsRecorder

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordManagerMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I4d20385eb2de80c4ca5e53816d22b9652abb5b61
Reviewed-on: https://chromium-review.googlesource.com/577554
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488192}
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/password_manager_metrics_recorder.h
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/9dc9d281b4bd298555bcbc112e2911a3d4a67959/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83609260044160cb960f95b6f12346161e2f248

commit a83609260044160cb960f95b6f12346161e2f248
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 20 12:47:05 2017

Delay binding of SourceId to URL in PasswordFormMetricsRecorder

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordFormMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I0a7c654ddc1a866e4abbe51206f62949500b5ba9
Reviewed-on: https://chromium-review.googlesource.com/577887
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488214}
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/a83609260044160cb960f95b6f12346161e2f248/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9a55da916812e899e9e54c2507df001f89e5fa

commit ca9a55da916812e899e9e54c2507df001f89e5fa
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 20 14:01:34 2017

Cleanups for PasswordFormManager

Bug: 732846
Change-Id: Ic1266587516270979e7077a526b8a951cb9d1c76
Reviewed-on: https://chromium-review.googlesource.com/570425
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488231}
[modify] https://crrev.com/ca9a55da916812e899e9e54c2507df001f89e5fa/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/ca9a55da916812e899e9e54c2507df001f89e5fa/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/ca9a55da916812e899e9e54c2507df001f89e5fa/components/password_manager/core/browser/password_form_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b931c1a2426f987da366402896d88eb55b2510

commit a0b931c1a2426f987da366402896d88eb55b2510
Author: Dominic Battre <battre@chromium.org>
Date: Fri Aug 25 19:40:04 2017

Record UKMs for users clicking on Show all passwords

Bug: 732846
Change-Id: I85737dbe848820117dea01c7944bb139454e751b
Reviewed-on: https://chromium-review.googlesource.com/635124
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497498}
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/password_manager_metrics_recorder.h
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/a0b931c1a2426f987da366402896d88eb55b2510/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4

commit 7f3cb30864d343c79759e6cb88aec4aa2fd9eee4
Author: Dominic Battre <battre@chromium.org>
Date: Wed Sep 20 08:30:56 2017

UKM/UMA Recording for editing usernames and passwords

This CL moves the recording of UKM metrics for the case when the user edits a
the username in the password save bubble to a proper place. Before this CL, we
would record an edit event even in case the user edited the username but did
not save the credential.

The CL also introduces UKM/UMA recording in case we selected the wrong password
field for saving and the user fixes that.

Bug: 732846
Change-Id: I75dd18480a035f3176e1d4fc9ea8cfa21bc6d04c
Reviewed-on: https://chromium-review.googlesource.com/668371
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503087}
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7f3cb30864d343c79759e6cb88aec4aa2fd9eee4/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d21041d4d1342713aba41f8474cf7cff3647e05b

commit d21041d4d1342713aba41f8474cf7cff3647e05b
Author: Dominic Battre <battre@chromium.org>
Date: Thu Nov 02 02:26:05 2017

Migrate User.ActionSimplified metric to new counting style

Processed UKM logs retain only a single value per event and metric. This means
that different actions override each other in the User.ActionSimplified metric.
This CL deprecates the old metric and introduces a unique counter for each
metric.

Bug: 732846
Change-Id: I7cc48241300a7f4bf9e428635b09156a4bed6655
Reviewed-on: https://chromium-review.googlesource.com/743501
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513381}
[modify] https://crrev.com/d21041d4d1342713aba41f8474cf7cff3647e05b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/d21041d4d1342713aba41f8474cf7cff3647e05b/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/d21041d4d1342713aba41f8474cf7cff3647e05b/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/d21041d4d1342713aba41f8474cf7cff3647e05b/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/d21041d4d1342713aba41f8474cf7cff3647e05b/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/779723641ff328aefba94c39ef6f9989cdc7ad43

commit 779723641ff328aefba94c39ef6f9989cdc7ad43
Author: Dominic Battre <battre@chromium.org>
Date: Mon Apr 09 10:31:11 2018

Record form and URL signatures in UKM

This CL introduces low entropy hashes of password form signatures and URLs.
This allows us to distinguish different forms on a page as well as different
pages for which we cannot record the full URL in UKM.

Bug: 732846
Change-Id: Ie98ef254286890310f6b6b5a2e3026260b65b676
Reviewed-on: https://chromium-review.googlesource.com/977904
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549141}
[modify] https://crrev.com/779723641ff328aefba94c39ef6f9989cdc7ad43/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/779723641ff328aefba94c39ef6f9989cdc7ad43/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/779723641ff328aefba94c39ef6f9989cdc7ad43/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/779723641ff328aefba94c39ef6f9989cdc7ad43/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/779723641ff328aefba94c39ef6f9989cdc7ad43/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/061f70757acaab80075714aaa2f93c532e26c38c

commit 061f70757acaab80075714aaa2f93c532e26c38c
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jul 05 15:16:45 2018

Record UKMs if a manual save fallback is offered to the user

This CL introduce a UKM metric that tells us if a manual fallback for password
saving was offered, which means that the user typed a not yet stored credential
into a password form. The purpose of this is to see whether we see such sites
where manual fallback is offered but form submissions are not observed.

Bug: 732846
Change-Id: If2bce7b0e7219f84880110218b8ea6d1d955c165
Reviewed-on: https://chromium-review.googlesource.com/1126932
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572797}
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/061f70757acaab80075714aaa2f93c532e26c38c/tools/metrics/ukm/ukm.xml

I would like to request merging crrev.com/572797 to M68. This only a metric that landed in 69.0.3483.0. I have not seen any related crashes in 3483.0, 3483.1, 3484.0 and 3485.0.

This should be save. It would be very valuable for us to get this metric rolled out quickly for finding sites where the password manager is broken.

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved - branch:3440

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e56445f9f934bb96053cdde8fc2b970e296b94

commit d6e56445f9f934bb96053cdde8fc2b970e296b94
Author: Dominic Battre <battre@chromium.org>
Date: Tue Jul 10 20:14:28 2018

Record UKMs if a manual save fallback is offered to the user

This CL introduce a UKM metric that tells us if a manual fallback for password
saving was offered, which means that the user typed a not yet stored credential
into a password form. The purpose of this is to see whether we see such sites
where manual fallback is offered but form submissions are not observed.

TBR=battre@chromium.org

(cherry picked from commit 061f70757acaab80075714aaa2f93c532e26c38c)

Bug: 732846
Change-Id: If2bce7b0e7219f84880110218b8ea6d1d955c165
Reviewed-on: https://chromium-review.googlesource.com/1126932
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#572797}
Reviewed-on: https://chromium-review.googlesource.com/1131940
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#640}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/d6e56445f9f934bb96053cdde8fc2b970e296b94/tools/metrics/ukm/ukm.xml