New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732839 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: ----



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Win7 (dbg)

Project Member Reported by dalecur...@chromium.org, Jun 13 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Win7 (dbg)

Builders failed on: 
- WebKit Win7 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29


external/wpt/payment-request/payment-request-constructor-crash.https.html is flaky on Win Dbg; seems to have come from recent wpt import:

130c37fb7f418cc6cfebda67596f365c3ffcb19c
 
Labels: -Pri-1 Pri-3
TestExpectations update in flight. Dropping to p3.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfe6ca7a755f69fe8a8bcc6986f1edd5cd0860aa

commit bfe6ca7a755f69fe8a8bcc6986f1edd5cd0860aa
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jun 13 17:41:06 2017

Mark payment-request-constructor-crash.https.html flaky.

BUG= 732839 
TEST=none
TBR=kochi

Change-Id: I7a05c746b6c704f16595faa0c26cad9b80328a6e
Reviewed-on: https://chromium-review.googlesource.com/533653
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479062}
[modify] https://crrev.com/bfe6ca7a755f69fe8a8bcc6986f1edd5cd0860aa/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Removing sheriff tracking since these have workarounds in place.

Comment 4 by kochi@chromium.org, Jun 29 2017

Components: Blink>Payments
I just imported then-latest WPT, not knowledgeable how to fix it...

Will ask the author intention and expectation of this test.
https://github.com/w3c/web-platform-tests/pull/6108

From the filename, I suppose "Crash" is the expectation, so this test may
be working as expected ;)

Adding Blink>Payments for their attention.

Comment 5 by kochi@chromium.org, Jun 29 2017

Cc: kochi@chromium.org
Owner: rouslan@chromium.org
Adding rouslan@ as he was involved in this test review there on GitHub.

If it is not appropriate, please hint who is the best person to assign,
or just assign back to me.

Comment 6 by kochi@chromium.org, Jun 29 2017

Upstream PR created:
https://github.com/w3c/web-platform-tests/pull/6423

If this change is merged and pulled in to Blink, we can try
removing the line in TestExpectations.

Current flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=payment-request-constructor

Comment 7 by kochi@chromium.org, Jun 29 2017

Cc: -kochi@chromium.org rouslan@chromium.org
Owner: kochi@chromium.org
Status: Started (was: Assigned)
Cc: anthonyvd@chromium.org
Anthony: can you open https://w3c-test.org/payment-request/payment-request-constructor-crash.https.html on canary in Windows and verify that it prints PASS within a reasonable amount of time? It takes a couple of seconds on Android.

Comment 9 by kochi@chromium.org, Jun 29 2017

Re #8 I tested it on my win10 desktop and all 10 tests PASSed for several times.
According to devtools the test script execution took ~400ms on 4GHz core i7.
The slow expectation in the WPT test itself is imported at
https://chromium-review.googlesource.com/c/555835/

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b72e254883853b9f1e8ee5dc013dff6c2dc5b05a

commit b72e254883853b9f1e8ee5dc013dff6c2dc5b05a
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Mon Jul 03 10:15:33 2017

Remove timeout TestExpectation

This expectation is specified in the upstream wpt test
https://github.com/w3c/web-platform-tests/pull/6423

and the change is already imported at
https://chromium-review.googlesource.com/c/555835/

So this expectation is no longer necessary.

BUG= 732839 

Change-Id: I34aeb2899d349ba73156535344b8f0398b75662b
Reviewed-on: https://chromium-review.googlesource.com/558751
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483977}
[modify] https://crrev.com/b72e254883853b9f1e8ee5dc013dff6c2dc5b05a/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment