New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Remove RemoteSuggestion::CreateForTesting

Project Member Reported by vitaliii@chromium.org, Jun 13 2017

Issue description

1) CreateFromProto is easy to use (there is an example in tests).
2) There is only one client.
3) The result is not complete, which may cause difficult to find issues in tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2284a517a1a9ed31c1491b4de9c24054c42f52c1

commit 2284a517a1a9ed31c1491b4de9c24054c42f52c1
Author: Vitalii Iarko <vitaliii@chromium.org>
Date: Fri Jun 16 10:21:06 2017

[NTP::Cleanup] Remove RemoteSuggestion::CreateForTesting.

This CL removes RemoteSuggestion::CreateForTesting and rewrites one place where it was used to use CreateFromProto. Reasons:
1) CreateFromProto is easy to use (there is an example in tests).
2) There is only one client.
3) The result is not complete, which may cause difficult to find issues in tests.

Bug:  732831 ,733129
Change-Id: I53859f2edf7495c0437871487e7f5e277d6a0c2f
Reviewed-on: https://chromium-review.googlesource.com/533157
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480008}
[modify] https://crrev.com/2284a517a1a9ed31c1491b4de9c24054c42f52c1/components/ntp_snippets/remote/remote_suggestion.cc
[modify] https://crrev.com/2284a517a1a9ed31c1491b4de9c24054c42f52c1/components/ntp_snippets/remote/remote_suggestion.h
[modify] https://crrev.com/2284a517a1a9ed31c1491b4de9c24054c42f52c1/components/ntp_snippets/remote/remote_suggestions_database_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment