GpuDisplayProvider should use the same RendererSettings as Chrome.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8599312ad0acfc33ec3bb00bc6c7b83aca7a0dfc commit 8599312ad0acfc33ec3bb00bc6c7b83aca7a0dfc Author: Alex Zhang <staraz@chromium.org> Date: Thu Jul 20 18:27:47 2017 Return true in BufferFormat enum traits when format is UYVY_422 Added the missing return true and unit tests for both BufferFormat and BufferUsage enum traits. Bug: 732825 Change-Id: Idd41676f01a11f7666bf2c1c07621b4b9eae6b4a Reviewed-on: https://chromium-review.googlesource.com/578211 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488316} [modify] https://crrev.com/8599312ad0acfc33ec3bb00bc6c7b83aca7a0dfc/ui/gfx/mojo/buffer_types_struct_traits.h [modify] https://crrev.com/8599312ad0acfc33ec3bb00bc6c7b83aca7a0dfc/ui/gfx/mojo/struct_traits_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00 commit bcce8b135d29e3d5f30ec3dd93dce8b44d392c00 Author: Alex Zhang <staraz@chromium.org> Date: Thu Jul 20 20:17:24 2017 Move cc::RendererSettings to Viz RendererSettings is consumed by DirectRenderer and its subclasses. Renderers are part of viz so RenderSettings should also be in viz. It is moved to common because browser is going to send RendererSettings initialized via command line flags to Viz. The rest of the CL updates includes, forward declarations and namespaces as appropriate. Bug: 722935 , 732825 Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271 TBR=boliu@chromium.org, piman@chromium.org, sadrul@chromium.org Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271 Reviewed-on: https://chromium-review.googlesource.com/579592 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#488379} [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/android_webview/browser/surfaces_instance.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/BUILD.gn [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/direct_renderer.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/direct_renderer.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/gl_renderer.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/gl_renderer.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/gl_renderer_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/overlay_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/software_renderer.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/software_renderer.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/output/software_renderer_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/resources/resource_provider.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/test/layer_tree_pixel_test.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/test/layer_tree_test.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/test/layer_tree_test.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/test/pixel_test.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_perftest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_pixeltest_blending.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_unittest_context.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_host_unittest_copyrequest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/cc/trees/layer_tree_settings.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/common/BUILD.gn [rename] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/common/display/renderer_settings.cc [rename] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/common/display/renderer_settings.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/display/display.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/display/display.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/display/display_scheduler.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/display/display_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/display_embedder/gpu_display_provider.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/test/test_layer_tree_frame_sink.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/components/viz/test/test_layer_tree_frame_sink.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/content/browser/compositor/gpu_process_transport_factory.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/content/renderer/android/synchronous_layer_tree_frame_sink.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/content/renderer/gpu/compositor_dependencies.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/content/test/layouttest_support.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/ui/aura/mus/mus_context_factory.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/ui/compositor/compositor_util.cc [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/ui/compositor/compositor_util.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/ui/compositor/test/fake_context_factory.h [modify] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/ui/compositor/test/in_process_context_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de2037a5b5e0d6ffd72547f3438a3790e46ebb08 commit de2037a5b5e0d6ffd72547f3438a3790e46ebb08 Author: Alex Zhang <staraz@chromium.org> Date: Fri Jul 21 17:25:27 2017 ResourceSettings struct traits To plumb RendererSettings through between browser and viz, we need struct traits for it and its members. ResourceSettings is a member of RendererSettings. This CL adds struct traits for ResourceSettings and a unit test for the struct traits. Bug: 732825 Change-Id: I03010130b3614cc316f6fc234dea4b5bfbf3fbf5 Reviewed-on: https://chromium-review.googlesource.com/575209 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488689} [modify] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/BUILD.gn [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/BUILD.gn [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/DEPS [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/OWNERS [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/resource_settings.mojom [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/resource_settings.typemap [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/resource_settings_struct_traits.cc [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/resource_settings_struct_traits.h [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/struct_traits_unittest.cc [add] https://crrev.com/de2037a5b5e0d6ffd72547f3438a3790e46ebb08/services/viz/public/interfaces/compositing/typemaps.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/563abfa78490bec1a1dea4e9f93394d87dfd2147 commit 563abfa78490bec1a1dea4e9f93394d87dfd2147 Author: Alex Zhang <staraz@chromium.org> Date: Sun Jul 23 14:29:48 2017 RendererSettings Struct Traits Add struct traits for RendererSettings and a unit test. The struct traits will be used to pass RendererSettings from browser to viz. Bug: 732825 Change-Id: I9b1d4b12e479d26dd3794ef2c5c134e7a23ac529 Reviewed-on: https://chromium-review.googlesource.com/581508 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#488886} [modify] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/BUILD.gn [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/BUILD.gn [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/DEPS [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/OWNERS [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/renderer_settings.mojom [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/renderer_settings.typemap [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.cc [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.h [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/struct_traits_unittest.cc [add] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/compositing/privileged/interfaces/typemaps.gni [modify] https://crrev.com/563abfa78490bec1a1dea4e9f93394d87dfd2147/services/viz/public/interfaces/compositing/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13161e3891173cfc2e60ce2b77e8243ebe3720d9 commit 13161e3891173cfc2e60ce2b77e8243ebe3720d9 Author: Alex Zhang <staraz@chromium.org> Date: Fri Jul 28 18:06:09 2017 [viz]Pass RendererSettings From Browser To Viz GpuProcessTransportFactory creates a RendererSettings based on the command line flags using ui::CreateRendererSettings before using it to create a viz::Display. We want to mimic this behavior in mus. This CL moves the creation of RendererSettings from GpuDisplayProvider::CreateDisplay (viz process) to ServerWindowCompositorFrameSinkManager (browser) before plumbing it to viz via mojo. Bug: 732825 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic81b0e0e4f84be3f16af58cf190b76e84c7c147a Reviewed-on: https://chromium-review.googlesource.com/585598 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#490462} [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/components/viz/service/display_embedder/display_provider.h [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/components/viz/service/display_embedder/gpu_display_provider.cc [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/components/viz/service/display_embedder/gpu_display_provider.h [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/components/viz/service/frame_sinks/frame_sink_manager_impl.cc [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/components/viz/service/frame_sinks/frame_sink_manager_impl.h [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/services/ui/ws/frame_sink_manager_client_binding.cc [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/services/ui/ws/frame_sink_manager_client_binding.h [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/services/ui/ws/server_window_compositor_frame_sink_manager.cc [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/services/viz/compositing/privileged/interfaces/frame_sink_manager.mojom [modify] https://crrev.com/13161e3891173cfc2e60ce2b77e8243ebe3720d9/ui/compositor/compositor_util.cc
Comment 1 by bugdroid1@chromium.org
, Jul 20 2017