New issue
Advanced search Search tips

Issue 732818 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocked on:
issue 808836

Blocking:
issue 749505



Sign in to add a comment

Use Job objects in Swarming task

Project Member Reported by maruel@google.com, Jun 13 2017

Issue description

Goal:

Properly contain Swarming tasks. There is two goals:
- Enable enforcing limits, like number of processes.
- Detect the whole process group lifetime.

We are particularly interested in the later, especially as part of making issue 732811 much better. Issue 732811 would likely still be needed (e.g. a complete host process list) as on Windows, it is still fairly trivial to escape the job object.

Nested job objects are only supported on Windows 8 and later yet many Swarming tasks actively use job objects internally.
Ref: https://msdn.microsoft.com/en-us/library/windows/desktop/hh448388.aspx

So there are two options on Windows 7:
- Only set the job object when requested at task recreation, for the subset of tasks which do not use job object as part of the task
- Only use the job object on Win8 and later

I'm learning towards the later as the former represents a lot of management that will likely never be done properly.


 
Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google

Comment 3 by mar...@chromium.org, Sep 12 2017

Cc: jbudorick@chromium.org

Comment 4 by mar...@chromium.org, Sep 12 2017

Implementation would be in run_isolated.py
Issue 764493 is the equivalent task for linux
Blocking: 749505
Blocking: 808836

Comment 7 by mar...@chromium.org, Feb 21 2018

Blocking: -808836

Comment 8 by mar...@chromium.org, Feb 21 2018

Blockedon: 808836

Sign in to add a comment