New issue
Advanced search Search tips

Issue 732812 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

VR: fix positioning of the capturing indicators

Project Member Reported by asimjour@chromium.org, Jun 13 2017

Issue description

The capturing indicators are positioned on top of the main content in a hard coded positions. We need to make sure that their position updates based on the number of the indicators that are shown.

 
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc3a18b2ecfaec67f409b94d3832fa49c8dbd81e

commit fc3a18b2ecfaec67f409b94d3832fa49c8dbd81e
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Tue Jun 13 20:49:33 2017

Remove hardcoded position and size of the indicators

Introduce new constants and remove the hardcoded numbers.
This is small clean up before introducing a linear layout.

BUG= 732812 

Change-Id: I80112b18fdeef006b1ab0ae8da75f730d6ea766e
Reviewed-on: https://chromium-review.googlesource.com/533493
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479141}
[modify] https://crrev.com/fc3a18b2ecfaec67f409b94d3832fa49c8dbd81e/chrome/browser/android/vr_shell/ui_scene_manager.cc

Labels: VR-BBB M-61
Owner: cjgrant@chromium.org
Claiming this as I have a CL to address it.
Status: Fixed (was: Assigned)
This was fixed by https://codereview.chromium.org/2950173002/

Sign in to add a comment