New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732797 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Reenable testAutoTranslate.

Project Member Reported by stkhapugin@chromium.org, Jun 13 2017

Issue description

This test is disabled as it is failing on downstream bots. It needs to be reenabled. 
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09492e644e5e19113632e91b3c5f7d59939645ba

commit 09492e644e5e19113632e91b3c5f7d59939645ba
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Jun 13 14:34:46 2017

Disable TranslateTestCase.testAutoTranslate.

This test is failing on downstream Chrome iOS bots and needs to be
fixed. Disabling it in order to make the tree green.

BUG= 732797 
R=sdefresne

Review-Url: https://codereview.chromium.org/2936693003
Cr-Commit-Position: refs/heads/master@{#479013}

[modify] https://crrev.com/09492e644e5e19113632e91b3c5f7d59939645ba/ios/chrome/browser/translate/translate_egtest.mm

Cc: baxley@chromium.org
Test failure is caused by https://codereview.chromium.org/2798773002.

-  [[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewContainingText(
-                                          "Translated")]
-      assertWithMatcher:grey_notNil()];
+  [ChromeEarlGrey waitForWebViewContainingText:"Translated"];

-  [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::WebViewContainingText("link")]
-      assertWithMatcher:grey_nil()];
+  [ChromeEarlGrey waitForWebViewContainingText:"link"];

Two different calls to EarlGrey +selectElementWithMatcher:assertWithMatcher: (second parameter is different) are replaced by the same call to ChromeEarlGrey +waitForWebViewContainingText: ...

But I think the original code was incorrect (as baxley said that using grey_nil() is incorrect and plan to remove all of them as state in https://codereview.chromium.org/2798033003/).

Working on a fix to the test.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70e3ecf863906504f27bf721ec12f00955faccd

commit a70e3ecf863906504f27bf721ec12f00955faccd
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jun 13 16:43:01 2017

[ios] Re-enable testAutoTranslate EarlGrey test.

The refactoring in https://codereview.chromium.org/2798773002
incorrectly flipped the condition of one of the EarlGrey wait
from waiting for a page *without* the word "link" to waiting
for a page *with* that word.

Add +waitForWebViewContainingText: method to ChromeEarlGrey
to wait for a web view not containing a word and restore the
proper condition in the test.

Use base::StringPrintf() to generate some of the URLs to use
the constants instead of duplicating the strings (this made
the code easier to debug).

BUG= 732797 

Change-Id: I02ac75dcc1c103f56cbd0107160fc2088750b0d4
Reviewed-on: https://chromium-review.googlesource.com/533336
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479045}
[modify] https://crrev.com/a70e3ecf863906504f27bf721ec12f00955faccd/ios/chrome/browser/translate/translate_egtest.mm
[modify] https://crrev.com/a70e3ecf863906504f27bf721ec12f00955faccd/ios/chrome/test/earl_grey/chrome_earl_grey.h
[modify] https://crrev.com/a70e3ecf863906504f27bf721ec12f00955faccd/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment