Issue metadata
Sign in to add a comment
|
Regression: Cancel Button appears chopped on changing browser language to French on chrome://settings/clearBrowserData
Reported by
aiman.an...@etouch.net,
Jun 13 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3128.0 (Official Build) 4138c6d4e9f036df01c2a6092a242a3aa39b6afc-refs/heads/master@{#478527}(32/64 Bit). OS: Windows(7,8,8.1,10). Steps to reproduce: 1.Launch Chrome, go to chrome://settings, change browser language to 'French' from chrome://settings/languages. 2.Relaunch chrome, go to chrome://settings/appearacne and change Font Size to 'Very Large' . 3.Go to chrome://settings/clearBrowserData, observe Cancel Button. Actual Result: Cancel Button is aligned to left and appears chopped. Expected Result: Cancel Button should not appear chopped. This is regression issue broken in 'M 60' and will soon update the bisect info: Manual Bisect Info: Good Build 60.0.3089.0 Bad Build 60.0.3090.0 Note: Issue is not reproducible on MAC and LINUX OS.
,
Jun 13 2017
,
Jun 13 2017
,
Jun 13 2017
,
Jun 19 2017
,
Jun 19 2017
,
Jul 3 2017
Thanks for your feedback. We're internally triaging the bug and it's currently in progress. We'll update this thread once it's fixed.
,
Jul 11 2017
,
Sep 20 2017
Hi All, Please see the below response of the language POC: ¨Thank you for your feedback. I am afraid there is nothing we can do on the linguists side since we cannot make the button shorter.¨ Regards!
,
Sep 20 2017
,
Sep 20 2017
Thanks! I´ll report it back to the language POC. Regards!
,
Sep 22 2017
The label of this button is going to change to "Clear data" with the new CBD ui. That should solve this issue.
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db054f2e008d4bbb983d5f13ad983acba43df555 commit db054f2e008d4bbb983d5f13ad983acba43df555 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Sep 25 09:56:09 2017 Margin, color and text tweaks for CBD This CL changes the button label from "Clear browsing data" to "Clear data", the tab text color to blue and a different grey and makes some improvements to the margins around "Time range". Before: https://screenshot.googleplex.com/HOySYiU6gtx.png After: https://screenshot.googleplex.com/6Jk2Y1jok5C.png Bug: 725401 , 732761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f52f248513d3cfaeecc807d1d6a17b7863cb4bc Reviewed-on: https://chromium-review.googlesource.com/678508 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504015} [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/app/settings_strings.grdp [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Sep 26 2017
The new dialog is still behind the "tabs-in-cbd" flag but I'm about to enable it by default and launch the dialog in M63.
,
Sep 26 2017
Hi All, This has now been fixed by the linguists and it is now on the live UI. Please see the attached screenshot. Regards!
,
Sep 27 2017
,
Sep 27 2017
Thanks for the verification. Regards! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jun 13 2017Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)