Aka: scripts/tools/buildbot_tool.py genall should be a noop on ToT. But it isn't. It produces a bunch of changes, which suggests that some folks either didn't update their builders.pyl files or forgot to run the script.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3 commit 6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Jul 18 00:21:33 2017 Rework buildbot-tool to better be able to keep things in sync. Apparently people have been modifying the files generated by buildbot-tool instead of modifying builders.pyl and re-running buildbot-tool to keep them in sync. This change reworks buildbot-tool to add a `check` command to make sure the files are in sync, and adds a (for now commented-out) presubmit check to enforce this. Once I land a follow-up CL to update the files and a matching one for the internal repos, I can uncomment the presubmit checks. R=dnj@chromium.org BUG= 732748 Change-Id: I3763d4c73da8a489bb520d3299cd54813a8e4f52 Reviewed-on: https://chromium-review.googlesource.com/573140 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3/PRESUBMIT.py [modify] https://crrev.com/6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3/scripts/tools/unittests/buildbot_tool_test.py [modify] https://crrev.com/6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3/scripts/common/fake_filesystem.py [modify] https://crrev.com/6b31d728bd8f0c6d3177d014f98dfe0d4da05fd3/scripts/tools/buildbot_tool.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/96b66d4aed6c53306efb5323fc42af5386232132 commit 96b66d4aed6c53306efb5323fc42af5386232132 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Jul 19 00:45:49 2017 Sync up builders.pyl files for the external builders. This CL updates the builders.pyl files and the generated files for all of the external (public) buildbot masters that use builders.pyl-based definitions. Mostly this just involves updating master_alt_port and the pubsub properties. R=dnj@chromium.org BUG= 732748 Change-Id: I0ff3a8d8baf460b0c7492d13c80cb9f2bad971b0 Reviewed-on: https://chromium-review.googlesource.com/573142 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.catapult/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.catapult/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.wasm.llvm/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.gyp/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.android/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.pdfium/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.pdfium/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.chromium.android/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.custom_tabs_client/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.boringssl/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.tools.build/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.syzygy/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.goma/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.syzygy/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.android/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.gyp/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.catapult/master.cfg [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.android.fyi/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.custom_tabs_client/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.gyp/master.cfg [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.pdfium/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.boringssl/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.chromium.android.fyi/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.chromium.android/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.pdfium/builders.pyl [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.client.wasm.llvm/master_site_config.py [modify] https://crrev.com/96b66d4aed6c53306efb5323fc42af5386232132/masters/master.tryserver.client.catapult/builders.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/84544c3b681da9392f4f86e39bb6a09c94392fad commit 84544c3b681da9392f4f86e39bb6a09c94392fad Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Jul 19 19:48:41 2017 Improve the error handling in the revised buildbot-tool code. Bug: 732748 Change-Id: I6cac803b61911fb507c7aa7c24ab6d556c4508fd Reviewed-on: https://chromium-review.googlesource.com/576952 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/84544c3b681da9392f4f86e39bb6a09c94392fad/scripts/tools/buildbot_tool.py [modify] https://crrev.com/84544c3b681da9392f4f86e39bb6a09c94392fad/scripts/common/chromium_utils.py [modify] https://crrev.com/84544c3b681da9392f4f86e39bb6a09c94392fad/scripts/tools/unittests/buildbot_tool_test.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build/+/48a97c8d1bb3150b403161797e02ac2f0d3fe3ef commit 48a97c8d1bb3150b403161797e02ac2f0d3fe3ef Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Jul 20 00:06:37 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build/+/502cfe924c3e75d31715ec626ab1c021e73ad000 commit 502cfe924c3e75d31715ec626ab1c021e73ad000 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Sep 01 22:49:21 2017
I believe this is fixed apart from the WebRTC bots, which should be treated separately as they are not directly managed by chrome infra.
Comment 1 by dpranke@chromium.org
, Jun 14 2017Status: Assigned (was: Untriaged)