New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732745 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: 1
NextAction: 2017-06-16
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unnecessary blue focus ring overlap with any website url for ‘http’ site.

Reported by abom...@etouch.net, Jun 13 2017

Issue description

Chrome Version:61.0.3128.0 (Official Build)4138c6d4e9f036df01c2a6092a242a3aa39b6afc-refs/heads/master@{#478527}
OS: Mac (10.12.1,10.11.6)

What steps will reproduce the problem?
1. Launch chrome and navigate to about:blank or http://permission.site/ or https://dh480.badssl.com/
2. Click on Omnibox and press ‘Shift +Tab’ ,Observe.

Actual: Unnecessary blue focus ring overlap with website url.
Expected: Focus ring should not overlap.

This is non regression issue, seen from ‘M 60’ (60.0.3082.0) as it is newly added feature.

Note: Issue is not seen on Windows and Linux OS.

 
Actual.png
11.1 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged it so that it gets addressed
EstimatedDays: 1
NextAction: 2017-06-16
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
The NextAction date has arrived: 2017-06-16
Labels: Hotlist-Polish
Status: Started (was: Assigned)
Screenshots with <https://chromium-review.googlesource.com/#/c/chromium/src/+/713697>.
Screen Shot 2017-10-11 at 2.02.17 PM.png
6.1 KB View Download
Screen Shot 2017-10-11 at 2.02.26 PM.png
8.3 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c1cb6c6926f4a01ed7740b6b416a409c05ab23

commit b7c1cb6c6926f4a01ed7740b6b416a409c05ab23
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Oct 11 19:52:22 2017

cocoa: don't draw info icon focus ring over location bar text

This change insets the page info icon's focus ring when the page info icon is
just an icon (i.e., no text). In this case, the page info icon is right next to
the location bar text, so the focus ring overdraws the location bar text.

Bug:  732745 
Change-Id: Ide977186d299179d67a7d8bd94ccad52baecf1f2
Reviewed-on: https://chromium-review.googlesource.com/713697
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508076}
[modify] https://crrev.com/b7c1cb6c6926f4a01ed7740b6b416a409c05ab23/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.h
[modify] https://crrev.com/b7c1cb6c6926f4a01ed7740b6b416a409c05ab23/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm

Status: Fixed (was: Started)
Fix landed.

Comment 8 by rp...@etouch.net, Oct 12 2017

Rechecked the above issue in Mac OS (10.12.6) with latest canary chrome version 63.0.3238.0 and the issue is still reproducible.Kindly refer the attached screen cast for reference.
Current_Result.mov
1.2 MB Download
The fix may not have landed in the current canary - you may need to wait until tomorrow.

Sign in to add a comment