New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732734 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Heaviest Stack is seen blank in performance tab of devtools

Project Member Reported by keerthan...@techmahindra.com, Jun 13 2017

Issue description

Chrome Version:61.0.3128.0
OS:Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome and open devtools in any page(Eg: Hit F1 for help page)
(2)Click on performance tab and record.
(3)Now click on the Call tree tab and click on show Heaviest Stack icon and observe(Refer Video)

Expected:Some results should be seen in the Heaviest Stack 
Actual:Instead, Heaviest Stack is seen blank 


This is a Regression issue seen from M-59
Manual bisect info:
===================
Good Build: 58.0.3029.0
Bad Build:  59.0.3030.0

 
HeaviestStackActual.ogv
3.5 MB View Download
HeaviestStackExpected.ogv
3.0 MB View Download
Description: Show this description
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.5 using chrome version 61.0.3128.0
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: alph@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build:58.0.3029.0 (Revision:454471).
Bad build:59.0.3030.0 (Revision:454724).

You are probably looking for a change made after 454686 (known good), but no later than 454687 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/afdbe72408cda331d4e7e321b8b9a3a9710d383c..e1d1055a0cdbc0bccd1eb9c4fe396e96c3ddb565

From the CL above, assigning the issue to the concern owner

@alph: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2724373003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3129.0
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bdabb09d8141adb4491df0fef76ee67fe7e54f0

commit 2bdabb09d8141adb4491df0fef76ee67fe7e54f0
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Jun 14 02:44:40 2017

DevTools: Fix heaviest stack not updated on show.

Bug:  732734 
Change-Id: I771570c120678bd3cca31c466dabb447cc66e44b
Reviewed-on: https://chromium-review.googlesource.com/533721
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479260}
[modify] https://crrev.com/2bdabb09d8141adb4491df0fef76ee67fe7e54f0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/2bdabb09d8141adb4491df0fef76ee67fe7e54f0/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Comment 5 by alph@chromium.org, Jun 19 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M61 TE-Verified-61.0.3135.4
Verified the issue on windows 10, Mac 10.12.5 and Ubuntu 14.04 using chrome dev version #61.0.3135.4 as per comment #0

Observed that heaviest Stack in performance tab of dev tools showed some results. Hence, the fix is working as expected.

Attaching screen cast for reference.

Hence, adding the verified labels.

Thanks...!!
732734.mp4
2.4 MB View Download

Sign in to add a comment