New issue
Advanced search Search tips

Issue 732727 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Lack of ifdef guard in WorkletModuleTreeClient.h

Project Member Reported by ckulakow...@opera.com, Jun 13 2017

Issue description

Chrome Version: 61.0.3127.0
OS: all

We use "jumbo" compilation of blink in our project. The main idea is to compile some number of cc files as one compilation unit. It significantly speeds up compilation time of blink. With "jumbo" enabled there is compilation error due to lack of ifdef guard in file WorkletModuleTreeClient.h.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ebeebd9d4e9c9b0459f8adcfc1bcc5b7af08b5

commit e8ebeebd9d4e9c9b0459f8adcfc1bcc5b7af08b5
Author: ckulakowski <ckulakowski@opera.com>
Date: Tue Jun 13 11:38:46 2017

Add ifdef guard to WorkletModuleTreeClient.h

We use "jumbo" compilation of blink in our project. The main idea is
to compile some number of cc files as one compilation unit. It
significantly speeds up compilation time of blink. With "jumbo"
enabled there is compilation error due to lack of ifdef
guard in file WorkletModuleTreeClient.h.

BUG= 732727 

Review-Url: https://codereview.chromium.org/2935823003
Cr-Commit-Position: refs/heads/master@{#478967}

[modify] https://crrev.com/e8ebeebd9d4e9c9b0459f8adcfc1bcc5b7af08b5/third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h

Status: Fixed (was: Untriaged)

Sign in to add a comment