Adding some people from the initial pylint check in.

Note, both depot_tools/third_party/pylint and chromium/src/pylint are at version 1.4.1, which is a version from 2015. I believe the copy in depot_tools is used for presubmit lint checks.

I tried to update it last year and found that it wasn't as easy as I hoped - the newest versions of pylint have different dependencies and don't behave the same as older versions.

So, updating it would be nice, and could be tried again. Updating the copy in src independently from the copy in depot_tools would be possible and might be easier, but isn't ideal. Patching in that one fix would be a simple one-time fix for the locale issue on Mac.

I haven't seen this issue on any version of MacOS as far as I know (up to and including 10.12.5); maybe it depends on what your language settings are set to, or which shell you're using? For me LC_ALL isn't set in my environment, and LANG=en_US.UTF-8.

dpranke: Sorry, I meant LC_CTYPE, and it seems to happen both on bash and zsh for me. I don't know why it's set to an incomplete locale by default but it seems to be a common problem. Of course I could just fix this by exporting a proper locale in .profile but I think it's likely more people will have this problem and it may be easier to fix it for everyone.

It's mostly the pylint run in presubmit that's been causing issues for me. I'd be fine with just patching in the fix if it's hard to upgrade to a newer version.

I see. I don't have LC_CTYPE set either, but from looking at the comments in https://bugs.python.org/issue18378 this does seem to be a known issue.

I'm fine with upgrading pylint either way.