New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732711 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in memory.top_10_mobile at 477266:477371

Project Member Reported by alexclarke@chromium.org, Jun 13 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=732711

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDglrW2mggM


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2017


=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Please try rerunning the bisect.


If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_m_youtube_com_results_q_science

Revision                           Result                  N
chromium@477265                    6314588 +- 210490       6      good
chromium@477279                    6353053 +- 21796.3      6      good
chromium@477283                    6352054 +- 33784.2      9      good
chromium@477284                    6294841 +- 279929       6      good
chromium@477284,v8@c22ca7f73b      6257847 +- 405606       9      good
chromium@477285                    6385609 +- 132038       9      bad
chromium@477286                    6402183 +- 92536.7      6      bad
chromium@477292                    6402529 +- 93763.4      6      bad
chromium@477318                    6403130 +- 90611.8      6      bad
chromium@477371                    6429454 +- 88462.7      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976919058797241936

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4586006273064960


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 14 2017

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jgruber
  Commit : 866ee63c581393185de63319aae94b21fc4069dd
  Date   : Tue Jun 06 11:28:37 2017
  Subject: [string] Re-enable result caching for String.p.split

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_m_youtube_com_results_q_science
  Change       : 1.25% | 6309749.33333 -> 6388592.0

Revision                           Result                  N
chromium@477265                    6309749 +- 206759       6      good
chromium@477279                    6350489 +- 25552.3      6      good
chromium@477283                    6358869 +- 5737.36      6      good
chromium@477284                    6342687 +- 59097.9      6      good
chromium@477284,v8@c22ca7f73b      6312309 +- 247439       6      good
chromium@477284,v8@866ee63c58      6387571 +- 75177.0      6      bad       <--
chromium@477284,v8@a5838cc92b      6418175 +- 111523       6      bad
chromium@477285                    6402567 +- 91105.6      6      bad
chromium@477286                    6376963 +- 1494.47      6      bad
chromium@477292                    6429163 +- 91453.1      6      bad
chromium@477318                    6420220 +- 133143       9      bad
chromium@477371                    6388592 +- 71342.3      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976879772543303968

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4586006273064960


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
Some memory regressions are expected now that result caching is working as intended again.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 16 2017

Cc: tebbi@chromium.org
 Issue 734048  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

Cc: mlippautz@chromium.org
 Issue 733106  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

 Issue 733106  has been merged into this issue.
Issue 731059 has been merged into this issue.

Sign in to add a comment