New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732704 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.1% regression in blink_perf.bindings at 478604:478614

Project Member Reported by alexclarke@chromium.org, Jun 13 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=732704

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1sibugoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 15 2017

Cc: hpayer@chromium.org
Owner: hpayer@chromium.org

=== Auto-CCing suspected CL author hpayer@chromium.org ===

Hi hpayer@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : hpayer
  Commit : b011c781cf639194aa596eb9cbffb42cf63635e5
  Date   : Mon Jun 12 10:37:49 2017
  Subject: [heap] Reland use larger marking steps during external allocation pressure

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : structured-clone-long-string-deserialize/structured-clone-long-string-deserialize
  Change       : 14.90% | 12.4288233333 -> 14.2813033333

Revision                           Result                   N
chromium@478603                    12.4288 +- 0.534133      6      good
chromium@478606                    12.4423 +- 0.379561      6      good
chromium@478607                    12.4889 +- 0.224834      6      good
chromium@478607,v8@ee596af250      12.5216 +- 0.566389      6      good
chromium@478607,v8@c31302d031      12.5567 +- 0.405362      6      good
chromium@478607,v8@b011c781cf      14.4329 +- 0.243464      6      bad       <--
chromium@478607,v8@fb55a9cbd8      14.3644 +- 0.171746      6      bad
chromium@478608                    14.3498 +- 0.288473      6      bad
chromium@478609                    14.2921 +- 0.13091       6      bad
chromium@478614                    14.2813 +- 0.213359      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976919136578325008

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6625180106883072


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 24 2017

Cc: kraynov@chromium.org
 Issue 736366  has been merged into this issue.
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Cc: jbroman@chromium.org
+jbroman, blink_perf.bindings owner: unfortunately we didn't notice until now that hpayer was on leave, so this bug from June didn't get addressed. Should we follow up at this point?
Status: WontFix (was: Assigned)
Looks like this wasn't serious enough to look into.

Sign in to add a comment