Issue metadata
Sign in to add a comment
|
5.6%-458.8% regression in system_health.common_mobile at 478719:478752 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976919176560333168
,
Jun 13 2017
=== Auto-CCing suspected CL author mek@chromium.org === Hi mek@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Marijn Kruisselbrink Commit : dda8780efac5966b275b8b7beeabe951b9d9c133 Date : Mon Jun 12 19:42:06 2017 Subject: Implement retry behavior for several leveldb env methods in mojo env. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : system_health.common_mobile Metric : timeToFirstMeaningfulPaint_avg/load_games/load_games_lazors Change : 425.32% | 234.106333333 -> 1229.80483333 Revision Result N chromium@478718 234.106 +- 28.9664 6 good chromium@478719 226.053 +- 13.9055 6 good chromium@478720 1226.12 +- 10.4734 6 bad <-- chromium@478721 1226.97 +- 24.8674 6 bad chromium@478723 1226.43 +- 15.4779 6 bad chromium@478727 1225.25 +- 12.4953 6 bad chromium@478735 1229.11 +- 14.5925 6 bad chromium@478752 1229.8 +- 14.9875 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.common_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976919176560333168 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4600418572697600 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 13 2017
Hmm, that's unexpected... is this only happening on android webview, or also on any other platforms? Not sure how I would get that data... if only android webview, that suggests that some operation that should never fail is always failing on android webview (as it retries for ~1 second before giving up, matching the slow down).
,
Jun 13 2017
,
Jun 13 2017
And how do I get any data out of these runs? Is there some way to see what UMA data was logged for them for example? Also the "To Run This Test" command seems to be missing some prerequisite setup, so not sure how to reproduce this...
,
Jun 14 2017
Issue 732702 has been merged into this issue.
,
Jun 14 2017
You would need to build android chrome first before running the command. I don't believe UMA data is logged. You should be able to get traces out of telemetry (I think they're stored somewhere under tools/perf) and if you need additional tracing categories you can edit the telemetry python files.
,
Jun 14 2017
,
Jun 14 2017
Issue 733297 has been merged into this issue.
,
Jun 15 2017
,
Jun 15 2017
Issue 732721 has been merged into this issue.
,
Jun 15 2017
Issue 732771 has been merged into this issue.
,
Jun 15 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/469805742123ec65bdeea766d8960c5abd7f82e8 commit 469805742123ec65bdeea766d8960c5abd7f82e8 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Jun 15 19:33:41 2017 If the file to rename doesn't exist, return OK immediately. This matches the behavior of ChromiumEnv::RenameFile and should prevent at least some unnecesary retries of renames. Bug: 732701 , 732863 Change-Id: I76637ba5f1f081f3709add94f4a085f54be0e096 Reviewed-on: https://chromium-review.googlesource.com/537134 Reviewed-by: Michael Nordman <michaeln@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#479785} [modify] https://crrev.com/469805742123ec65bdeea766d8960c5abd7f82e8/components/leveldb/env_mojo.cc
,
Jun 15 2017
,
Jun 16 2017
I think this is fixed now
,
Jun 16 2017
Issue 732771 has been merged into this issue.
,
Jun 19 2017
Issue 733299 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Jun 13 2017