New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 732697 link

Starred by 2 users
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
eseckler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools event Network.requestIntercepted typo in param interceptionId

Project Member Reported by eseckler@chromium.org, Jun 13 2017 
from slack:

playing with https://chromedevtools.github.io/devtools-protocol/tot/Network/#event-requestIntercepted and I am wondering why the “InterceptionId” paramater is spelled “InterceptionId” (uppercase i) while in https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-continueInterceptedRequest is “interceptionId” (lowercase i)


-> looks like a typo in Network.requestIntercepted, it should be a lowercase i.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29e207dd862ae4f4ebf24a81b7e7634e213be7c2

commit 29e207dd862ae4f4ebf24a81b7e7634e213be7c2
Author: Alex Clarke <alexclarke@chromium.org>
Date: Wed Jun 14 08:18:23 2017

Fix typo in continueInterceptedRequest
The interceptionId paramater should start with a lower case i.

Bug:  732697 ,  702384 
Change-Id: Iaee18b918baf8551ad8d5005f99ddb8cab2fbf2e
Reviewed-on: https://chromium-review.googlesource.com/532996
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479325}
[modify] https://crrev.com/29e207dd862ae4f4ebf24a81b7e7634e213be7c2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[modify] https://crrev.com/29e207dd862ae4f4ebf24a81b7e7634e213be7c2/third_party/WebKit/Source/core/inspector/browser_protocol.json

Comment 2 by alexclarke@chromium.org, Jun 14 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment