Issue metadata
Sign in to add a comment
|
Regression: Chrome crashes on screen sharing through hangouts |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3129.0 dev OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and go to https://hangouts.google.com/ and sign in (2)Now video call any one and click on 3 dot menu and hit screen share (3)Now click on opened window and observe Expected: Chrome should not crash on screensharing. Actual: Instead chrome crashes on screen sharing. This is a regression issue. Will provide other info soon. Crash ids: c7e0c073f0000000 , 92104073f0000000
,
Jun 13 2017
Issue is also seen in todays dev candidate i.e:61.0.3128.0 Manual bisect info: ======================= Good Build:61.0.3124.0 Bad Build:61.0.3125.0
,
Jun 13 2017
Used code search for the file "native_desktop_media_list.cc" from above stack trace and suspecting the below change https://chromium.googlesource.com/chromium/src/+/35ec1444165dcb7f1416251d634e43b1950d1e20 sergeyu@: Could you please check if this is caused with respect to your change, if not please help us in reassign the issue to the right owner. Note: Since this is a recent regression observed on M61 adding RB-Dev please feel free to edit if this is not the case. Thanks!
,
Jun 13 2017
Spoke with sergeyu@ offline and he is working on a fix since the revert has other dependencies. I will request a merge to 3128 branch once the fix has been landed in trunk. Thank you!
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76ea4f567679fb6bdbe02d34bd6d57a66e02657b commit 76ea4f567679fb6bdbe02d34bd6d57a66e02657b Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Jun 13 18:47:09 2017 Fix crash in DesktopCapture API After crrev.com/478081 the same DesktopCaptureOptions were used for screen and window capturer. This means that the same X display was used on different threads, which is not supported. BUG= 732695 Change-Id: Ife46591ec8bf660e3675990867b578b8de4909e7 Reviewed-on: https://chromium-review.googlesource.com/534173 Reviewed-by: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#479080} [modify] https://crrev.com/76ea4f567679fb6bdbe02d34bd6d57a66e02657b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b6764f355d00b6a82fbdf764b136db855a1cd6d commit 5b6764f355d00b6a82fbdf764b136db855a1cd6d Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Jun 13 18:51:08 2017 Fix crash in DesktopCapture API After crrev.com/478081 the same DesktopCaptureOptions were used for screen and window capturer. This means that the same X display was used on different threads, which is not supported. BUG= 732695 TBR=sergeyu@chromium.org (cherry picked from commit 76ea4f567679fb6bdbe02d34bd6d57a66e02657b) Change-Id: Ife46591ec8bf660e3675990867b578b8de4909e7 Reviewed-on: https://chromium-review.googlesource.com/534173 Reviewed-by: Zijie He <zijiehe@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#479080} Reviewed-on: https://chromium-review.googlesource.com/534213 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/branch-heads/3128@{#3} Cr-Branched-From: 4138c6d4e9f036df01c2a6092a242a3aa39b6afc-refs/heads/master@{#478527} [modify] https://crrev.com/5b6764f355d00b6a82fbdf764b136db855a1cd6d/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
,
Jun 13 2017
should be fixed now
,
Jun 13 2017
Thank you sergeyu@ for quick fix and merge and Thank you manoranjanr@ for follow up. I'm triggering Linux Dev build from branch 3128.
,
Jun 13 2017
The above fix is working as intended on Latest Dev#61.0.3128.3 for Linux Ubuntu 14.04. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jun 13 2017Status: Untriaged (was: Unconfirmed)