New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732694 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Participants' hotlists:
In-Product-Help


Sign in to add a comment

Add a drop shadow to the In Product Help bubble

Project Member Reported by rachelis@chromium.org, Jun 13 2017

Issue description

We should add a drop shadow to the In Product Help bubble to ensure contrast with similarly colored pages.

Questions:
- is there an existing chrome drop shadow we can match (in terms of appearance)?


I'd propose that we separate out the inevitable shadow audit to make sure that we can quickly correct this (relatively small) issue, while addressing shadow consistency in the slightly longer term.

Ted suggested:
We could investigate drawing shadows ourselves using something like:
https://cs.corp.google.com/android/frameworks/support/core-ui/java/android/support/v4/widget/CircleImageView.java?q=setShadowLayer+package:%5Eandroid$+lang:java&dr=C&l=60

But I don't know the perf implications (but maybe with the infrequent IPH bubble usage, we could get away with a slightly less efficient path pre-L?)
 
Labels: M-61
Owner: hannahs@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hotlist-UX-Backlog-Hannahs
Cc: shaktisahu@chromium.org
Labels: -M-61 M-64 OS-Android
hannahs: Is this still the plan to look into on your end?
Components: UI>Browser>Mobile
Hi! Yes, my apologies, we have a last minute feature we needed to add in for M63 but will definitely get this in by M64. Thanks for your patience!

Sign in to add a comment