Add a drop shadow to the In Product Help bubble |
|||||
Issue descriptionWe should add a drop shadow to the In Product Help bubble to ensure contrast with similarly colored pages. Questions: - is there an existing chrome drop shadow we can match (in terms of appearance)? I'd propose that we separate out the inevitable shadow audit to make sure that we can quickly correct this (relatively small) issue, while addressing shadow consistency in the slightly longer term. Ted suggested: We could investigate drawing shadows ourselves using something like: https://cs.corp.google.com/android/frameworks/support/core-ui/java/android/support/v4/widget/CircleImageView.java?q=setShadowLayer+package:%5Eandroid$+lang:java&dr=C&l=60 But I don't know the perf implications (but maybe with the infrequent IPH bubble usage, we could get away with a slightly less efficient path pre-L?)
,
Jun 19 2017
,
Aug 23 2017
,
Sep 29 2017
hannahs: Is this still the plan to look into on your end?
,
Sep 29 2017
,
Sep 29 2017
Hi! Yes, my apologies, we have a last minute feature we needed to add in for M63 but will definitely get this in by M64. Thanks for your patience! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dtrainor@chromium.org
, Jun 14 2017