New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732683 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Sign-in Overlay is seen misplaced while logging into User

Project Member Reported by mmanchala@chromium.org, Jun 13 2017

Issue description

Chrome Version: 61.0.3128.0/9646.0.0 dev channel Candy,Minnie and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Sign out -> Now in Sign-Out Screen click on 'Add person'
(2)Sign into second user with valid credentials and observe Sign-in Overlay while signing in (Please refer Video)

Expected: Sign-in Overlay should not be misplaced while logging into User
Actual: Instead Sign-in Overlay is seen misplaced.

This is Regression Issue as same is working fine 61.0.3124.0/9632.0.0 dev channel Daisy

Note :
1.Issue is seen from second User whereas for First User sign-in overlay is not misplaced
2.Issue is not applicable to Linux and windows
 
Actual_SignInOverlay.mp4
4.4 MB View Download
Expected_SignInOverlay.mp4
5.2 MB View Download
Cc: r...@chromium.org wzang@chromium.org

Comment 2 by r...@chromium.org, Jun 13 2017

Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)
Reproducible on 61.0.3129.0/9647.0.0 - candy
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9

commit 27848b1c4ddb114bf2462ba8c6d46d9b49f489b9
Author: wzang <wzang@chromium.org>
Date: Fri Jun 16 02:04:44 2017

Fix misplacement of signin overlay and critical update message banner

This CL combines several small changes:

1) Fix  crbug.com/732921  by using offsetWidth instead of a fixed width
value when positioning.

2) Fix  crbug.com/732683  by combining .user-image and .pod classes. The
oobe container has another class also named as .user-image so they
interfere with each other.

3) CSS style changes, including ones for easy unlock icon
(updating assets is done by CL 2934193002) and removing the sign-in
badge per the new spec.

4) Correct tab order for public session pods, also make sure that the
focus correctly goes to other small pods after leaving the public pod,
by changing display:none to opacity:0.

5) Update border style for reset screen (capturing CL 2879593005)

BUG= 732921 ,  732683 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2936173002
Cr-Commit-Position: refs/heads/master@{#479921}

[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_screen_account_picker.css
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_row.css
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/account_picker/md_user_pod_template.html
[modify] https://crrev.com/27848b1c4ddb114bf2462ba8c6d46d9b49f489b9/ui/login/md_screen_container.css

Comment 5 by wzang@chromium.org, Jun 16 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9678.0.0, 61.0.3138.0

Sign in to add a comment