Warm-up search provider's service worker on omnibox signal |
||||||||
Issue descriptionWhen the omnibox predicts that a web search will likely be done, it could tell service worker machinery beforehand, so there is an opportunity to warm up the service worker before the navigation occurs. A tricky part is how to ensure the service worker and navigation use the same renderer process. This has some parts: - Add an API for the omnibox to call to signal that a search will likely occur. - Implement the prediction heuristics and call the API when appropriate. - Implement the warming up of the service worker.
,
Jun 15 2017
,
Jun 29 2017
,
Jun 30 2017
,
Jul 6 2017
Implementation currently in review: https://chromium-review.googlesource.com/c/559914
,
Jul 7 2017
Looking forward to it!
,
Jul 7 2017
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c commit 4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri Jul 07 21:32:13 2017 Start the search service worker when the user input looks like a query. Bug: 732681 Change-Id: Ic51430e0acdc22acfc778158ee328f973e7f1c45 Reviewed-on: https://chromium-review.googlesource.com/559914 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#485056} [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/chrome/browser/about_flags.cc [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/chrome/browser/flag_descriptions.h [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/components/omnibox/browser/autocomplete_controller.cc [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/components/omnibox/browser/autocomplete_controller.h [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/components/omnibox/browser/autocomplete_provider_client.h [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/4e448cb035ba21b8b72fc3cb88a981b4e3e7b27c/tools/metrics/histograms/enums.xml
,
Jul 10 2017
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8479b20511682f7042b6c5b2172710fafd2b406e commit 8479b20511682f7042b6c5b2172710fafd2b406e Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Jul 14 04:35:31 2017 service worker: Add targetted UMA for ActivatedWorkerPreparationForMainFrame This is to help track the effectiveness of warming up the service worker for search from the omnibox. This rather unfortunately adds a public content API since all the smarts about detecting Google Search URLs are (rightly) in //chrome but we want to log the UMA in //content. I think someday a patch like https://chromium-review.googlesource.com/c/566764/ can be landed that moves the UMA entirely to //chrome. Bug: 724337, 732681 Change-Id: I1a4671111c583a30963b5a34a1c4bc605fc07f14 Reviewed-on: https://chromium-review.googlesource.com/569550 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486673} [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/chrome/browser/chrome_content_browser_client_unittest.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/browser/service_worker/service_worker_metrics.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/browser/service_worker/service_worker_metrics.h [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/browser/service_worker/service_worker_metrics_unittest.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/browser/service_worker/service_worker_url_request_job.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/public/browser/content_browser_client.cc [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/content/public/browser/content_browser_client.h [modify] https://crrev.com/8479b20511682f7042b6c5b2172710fafd2b406e/tools/metrics/histograms/histograms.xml
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ab1c2e0fa0e7ecbf917106fed56ead16476a4ec commit 0ab1c2e0fa0e7ecbf917106fed56ead16476a4ec Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Aug 17 23:55:16 2017 Add OmniboxSpeculativeServiceWorkerStartOnQueryInput in fieldtrial_testing_config.json Bug: 732681 Change-Id: I5f2ed638ab583529df318515c3d7e259cf844663 Reviewed-on: https://chromium-review.googlesource.com/618200 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#495387} [modify] https://crrev.com/0ab1c2e0fa0e7ecbf917106fed56ead16476a4ec/testing/variations/fieldtrial_testing_config.json
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/567b14dde568b497082c1960564b427c9d71faf2 commit 567b14dde568b497082c1960564b427c9d71faf2 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Sep 19 02:02:46 2017 Add OmniboxCombinedSpeculativeServiceWorker study We already have OmniboxCombinedSpeculativeServiceWorker study on the server side. I think we need this test config on fieldtrial_testing_config.json. Bug: 732681 Change-Id: I568442e41a884b3995e50970a60e3f7309d2a513 Reviewed-on: https://chromium-review.googlesource.com/668349 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#502760} [modify] https://crrev.com/567b14dde568b497082c1960564b427c9d71faf2/testing/variations/fieldtrial_testing_config.json
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d17ac3325c55213f41da31d6f05c11a87b70dc2 commit 8d17ac3325c55213f41da31d6f05c11a87b70dc2 Author: Tsuyoshi Horo <horo@chromium.org> Date: Fri Oct 13 00:31:45 2017 Rename PrewarmingWithServiceWorker in fieldtrial_testing_config.json To align with the server side config. Bug: 732681 Change-Id: I4c2ff108344fe6c5cf203e14c1bccf799e1814c4 Reviewed-on: https://chromium-review.googlesource.com/710774 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#508565} [modify] https://crrev.com/8d17ac3325c55213f41da31d6f05c11a87b70dc2/testing/variations/fieldtrial_testing_config.json
,
Feb 9 2018
Hi, what url I can use to test this feature? I checked it on desktop and it seems it's not working with docs.google.com. Is it working on mobile version only?
,
Feb 9 2018
This is only hooked up to the service providers registered in the omnibox right now.
,
Feb 9 2018
So what are URLs for this service providers? And what do you mean by "registered in the omnibox"? Set as default search? I want to test, how it works and I suspect that it does not work as intended, at least in search query detection.
,
Feb 9 2018
Sorry, I missed the last part of your question. Yes, it's Android only for now. I think the omnibox uses the search providers here: chrome://settings/searchEngines.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/227d97f4d4a8102c77aaea14a4ac07ea9fff7c35 commit 227d97f4d4a8102c77aaea14a4ac07ea9fff7c35 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Mar 08 22:55:48 2018 Remove OmniboxCombinedSpeculativeServiceWorker field trial testing config. The "OmniboxCombinedSpeculativeServiceWorker" study has long expired and the "OmniboxSpeculativeServiceWorkerStartOnQueryInput" feature has been enabled by default in r541744. Bug: 732681 Change-Id: I08175813d67ed834eba31c080e5071248fb4a49e Reviewed-on: https://chromium-review.googlesource.com/954891 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541917} [modify] https://crrev.com/227d97f4d4a8102c77aaea14a4ac07ea9fff7c35/testing/variations/fieldtrial_testing_config.json |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by falken@chromium.org
, Jun 13 2017