Isolate should live in a top-level directory. See discussion on https://chromium-review.googlesource.com/c/527778/
Since you put yourself as owner, I'm changing this to assigned.
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff commit d52b666028d0e37b9b33eb6bd73d1938a3cd3fff Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 03:47:19 2017 Sever isolate package's dependency on client/internal. This is in preparation for moving the isolate package to its own top-level directory, where it will not have access to client/internal. BUG= 732677 Review-Url: https://codereview.chromium.org/2937663002 [modify] https://crrev.com/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff/client/isolate/format.go [modify] https://crrev.com/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff/client/isolate/format_test.go [modify] https://crrev.com/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff/client/isolate/isolate.go [modify] https://crrev.com/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff/client/isolate/isolate_test.go [modify] https://crrev.com/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff/client/isolate/utils.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2bf17973b3ef98d40feda9e113bcb8c6607b479b commit 2bf17973b3ef98d40feda9e113bcb8c6607b479b Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 03:55:49 2017 Break isolate cmd dependency on Canceler. BUG= 732677 Review-Url: https://codereview.chromium.org/2936713003 [modify] https://crrev.com/2bf17973b3ef98d40feda9e113bcb8c6607b479b/client/cmd/isolate/archive.go [modify] https://crrev.com/2bf17973b3ef98d40feda9e113bcb8c6607b479b/client/cmd/isolate/batch_archive.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/b903ee51e442ff3fdbe533b7e9cfec96139a8ad4 commit b903ee51e442ff3fdbe533b7e9cfec96139a8ad4 Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 04:11:09 2017 Refactor genjson processing code. BUG= 732677 Review-Url: https://codereview.chromium.org/2937583003 [modify] https://crrev.com/b903ee51e442ff3fdbe533b7e9cfec96139a8ad4/client/cmd/isolate/batch_archive.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/a4a9617ec3dc88d18d92653b0270f584fcbcc98e commit a4a9617ec3dc88d18d92653b0270f584fcbcc98e Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 04:20:00 2017 Remove ReadJSONFile Also some refactoring in batcharchive. BUG= 732677 Review-Url: https://codereview.chromium.org/2933273002 [modify] https://crrev.com/a4a9617ec3dc88d18d92653b0270f584fcbcc98e/client/cmd/isolate/batch_archive.go [modify] https://crrev.com/a4a9617ec3dc88d18d92653b0270f584fcbcc98e/client/internal/common/json.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/3b2cf368c09e435c41d69235e93ff7eb5980bd5b commit 3b2cf368c09e435c41d69235e93ff7eb5980bd5b Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 05:30:27 2017 Move WriteJSONFile to its sole caller's package, with some refactoring. BUG= 732677 Review-Url: https://codereview.chromium.org/2938823003 [modify] https://crrev.com/3b2cf368c09e435c41d69235e93ff7eb5980bd5b/client/cmd/isolate/batch_archive.go [delete] https://crrev.com/a4a9617ec3dc88d18d92653b0270f584fcbcc98e/client/internal/common/json.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/35426aab5e558df793b116a5f0c516633a32376b commit 35426aab5e558df793b116a5f0c516633a32376b Author: mcgreevy <mcgreevy@chromium.org> Date: Thu Jun 15 06:23:11 2017 Remove batcharchive dependency on common.IsDirectory BUG= 732677 Review-Url: https://codereview.chromium.org/2941963002 [modify] https://crrev.com/35426aab5e558df793b116a5f0c516633a32376b/client/cmd/isolate/batch_archive.go [modify] https://crrev.com/35426aab5e558df793b116a5f0c516633a32376b/client/internal/common/utils.go
I have no plans to work on this any further, and the impetus for doing it has passed. Closing WontFix.
Comment 1 by s...@google.com
, Jun 13 2017Components: -Infra>Platform Infra>Platform>Swarming Infra>Platform>Recipes
Status: Assigned (was: Untriaged)