New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 732669 link

Starred by 1 user
Status: Fixed
Owner:
█ zhaobin@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[cast_channel] Remove channel_auth parameter from CastSocketImpl ctor

Project Member Reported by zhaobin@chromium.org, Jun 13 2017 
CHANNEL_AUTH_NONE has been removed from the IDL. It would be good to clean up code comments and Remove channel_auth parameter from CastSocketImpl's ctor.

https://codereview.chromium.org/2925053005/diff/40001/components/cast_channel/cast_socket.h
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8

commit ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8
Author: zhaobin <zhaobin@chromium.org>
Date: Thu Jun 15 20:19:20 2017

[cast_channel] Clean up CastSocketImpl ctor parameters and ChannelAuthType usage

- Remove |owner_extension_id| (not used anymore) and |channel_auth| (should always be SSL_VERIFIED) from CastSocketImpl's ctor
- Remove ChannelAuthType from cast_channel_enum.h and clean up its usage thoughout the code

BUG= 732669 

Review-Url: https://codereview.chromium.org/2942743002
Cr-Commit-Position: refs/heads/master@{#479807}

[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_channel_enum.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_channel_enum.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_socket.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_transport.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_transport.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/components/cast_channel/cast_transport_unittest.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_api.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_apitest.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_enum_util.cc
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_enum_util.h
[modify] https://crrev.com/ebd6f8fd664d851ccc571bbd80ec0767d4bc40a8/extensions/browser/api/cast_channel/cast_channel_enum_util_unittest.cc

Comment 2 by zhaobin@chromium.org, Jun 20 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment